Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

102 test modify student #104

Merged
merged 6 commits into from
Nov 15, 2024
Merged

102 test modify student #104

merged 6 commits into from
Nov 15, 2024

Conversation

GiovanniMaerean
Copy link
Contributor

No description provided.

@GiovanniMaerean GiovanniMaerean linked an issue Nov 9, 2024 that may be closed by this pull request
Copy link
Collaborator

@elskater98 elskater98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

elskater98
elskater98 previously approved these changes Nov 13, 2024
@GiovanniMaerean GiovanniMaerean dismissed elskater98’s stale review November 13, 2024 16:22

The merge-base changed after approval.

elskater98
elskater98 previously approved these changes Nov 13, 2024
@GiovanniMaerean GiovanniMaerean dismissed elskater98’s stale review November 13, 2024 16:32

The merge-base changed after approval.

rogargon
rogargon previously approved these changes Nov 15, 2024
Copy link
Member

@rogargon rogargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but a future enhancement is needed for this feature to ensure that students can only update their own details, while admins may have the ability to edit anyone's.

@GiovanniMaerean GiovanniMaerean dismissed rogargon’s stale review November 15, 2024 16:27

The merge-base changed after approval.

@rogargon rogargon merged commit f7bb035 into main Nov 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Test Modify Student
5 participants