Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert to user_clicks only when user clicks on other user's listing. #552

Conversation

arunalex62
Copy link
Contributor

Description

Currently when a user clicks on their own listing, click recommendations are altered based on that click. But this should not happen.

Click recommendations should only be tuned when a user clicks on another user's listing.

Closes #548

How to Test

From a fresh user, create a new listing and then click on it in "My Listings".

Notice that your recommendations are unchanged.

Checklist

  • The code includes tests if relevant
  • I have actually self-reviewed my changes and done QA

@arunalex62 arunalex62 self-assigned this Jul 30, 2024
@arunalex62 arunalex62 requested a review from a team as a code owner July 30, 2024 23:57
@arunalex62 arunalex62 linked an issue Jul 30, 2024 that may be closed by this pull request
@arunalex62 arunalex62 changed the title Inserted to user_clicks only when user clicks on other user's listing. Insert to user_clicks only when user clicks on other user's listing. Jul 30, 2024
@arunalex62 arunalex62 merged commit 9ce62ac into master Jul 31, 2024
58 checks passed
@arunalex62 arunalex62 deleted the 548-fix-user-clicks-altering-recommendations-for-a-users-own-listings branch July 31, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix user clicks altering recommendations for a user's own listings.
2 participants