Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix user clicks altering recommendations for a user's own listings. #548

Closed
arunalex62 opened this issue Jul 30, 2024 · 0 comments · Fixed by #552
Closed

Fix user clicks altering recommendations for a user's own listings. #548

arunalex62 opened this issue Jul 30, 2024 · 0 comments · Fixed by #552
Assignees
@arunalex62
Labels
bug Something isn't working

Comments

@arunalex62
Copy link
Contributor

Describe the bug

When a user clicks on their listing (one they have created), this should not alter their user clicks recommendations.

To Reproduce

Steps to reproduce the behaviour:

  1. Create a new account and login.
  2. Create a new listing and click on it.
  3. Go to your recommendations and notice that your recommendations have been tuned based on the item you created.

Expected behaviour

This should not affect your recommendations if you click on your own listing.
@arunalex62 arunalex62 added the bug Something isn't working label Jul 30, 2024
@arunalex62 arunalex62 self-assigned this Jul 30, 2024
@arunalex62 arunalex62 mentioned this issue Jul 30, 2024
Merged
2 tasks
@arunalex62 arunalex62 linked a pull request Jul 30, 2024 that will close this issue
Insert to user_clicks only when user clicks on other user's listing. #552
Merged
2 tasks
arunalex62 added a commit that referenced this issue Jul 31, 2024
@arunalex62
Insert to user_clicks only when user clicks on other user's listing. (#…
9ce62ac 
…552)

# Description
Currently when a user clicks on their own listing, click recommendations
are altered based on that click. But this should not happen.

Click recommendations should only be tuned when a user clicks on another
user's listing.

Closes #548 

## How to Test
From a fresh user, create a new listing and then click on it in "My
Listings".

Notice that your recommendations are unchanged.

## Checklist
- [ ] The code includes tests if relevant
- [ ] I have *actually* self-reviewed my changes and done QA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arunalex62 arunalex62

Labels
bug Something isn't working
Projects
Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Insert to user_clicks only when user clicks on other user's listing. UVicMartletplace/martletplace
1 participant
@arunalex62