Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #361 #364

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Fix #361 #364

merged 2 commits into from
Apr 25, 2024

Conversation

paddyroddy
Copy link
Member

These were the only culprits

@paddyroddy paddyroddy added the bug Something isn't working label Apr 25, 2024
@paddyroddy paddyroddy self-assigned this Apr 25, 2024
@paddyroddy paddyroddy linked an issue Apr 25, 2024 that may be closed by this pull request
Links not rendered correctly in Documentation page on website #361
Closed
giordano
giordano approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, at least the GitHub file still renders the links correctly, but this is a case where #363 would be useful 😛

@paddyroddy
Copy link
Member Author

Looks good to me, at least the GitHub file still renders the links correctly

Well it did before too! Hence how this was missed

@paddyroddy paddyroddy merged commit 05a2698 into main Apr 25, 2024
15 checks passed
@paddyroddy paddyroddy deleted the fix-361 branch April 25, 2024 15:42
@paddyroddy paddyroddy mentioned this pull request Apr 29, 2024
Merged
@samcunliffe samcunliffe mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano approved these changes

Assignees

@paddyroddy paddyroddy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Links not rendered correctly in Documentation page on website
2 participants
@paddyroddy @giordano