-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude gnu.org and fsf.org from link checker #454
Conversation
Propose to exclude it as this is not the first time we've encountered this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion
# necessarily not real links - i.e. demos and to be filled by | ||
# cookiecutter values. | ||
args: | ||
"--verbose --exclude https://forum.image.sc/ --exclude docs/pages | ||
"--verbose --exclude https://forum.image.sc/ --exclude http://www.gnu.org --exclude http://fsf.org --exclude docs/pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"--verbose --exclude https://forum.image.sc/ --exclude http://www.gnu.org --exclude http://fsf.org --exclude docs/pages | |
"--verbose --exclude https://forum.image.sc/ --exclude | |
http://www.gnu.org --exclude http://fsf.org --exclude docs/pages |
@samcunliffe stop automerging like that! Otherwise, what is the point in reviewing? |
🤖 the automerge robot and our linters are happy with my linebreaks. |
That's because you wouldn't allow https://prettier.io/docs/en/options.html#prose-wrap |
Did I? That doesn't sound like a think I would block... We had it in |
Ha! Found it. @paddyroddy, I'm sorry to report that it was you that removed that: |
I'm fully aware, it was due to your markdown linking |
The link checker is timing out at gnu.org and fsf.org. Propose to exclude as this is not the first time we've encountered this. And we can't remove the links: it's part of the licenses.
Would unblock @renovate bot's many updates.