Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude gnu.org and fsf.org from link checker #454

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

samcunliffe
Copy link
Member

@samcunliffe samcunliffe commented Oct 1, 2024

The link checker is timing out at gnu.org and fsf.org. Propose to exclude as this is not the first time we've encountered this. And we can't remove the links: it's part of the licenses.

Would unblock @renovate bot's many updates.

Propose to exclude it as this is not the first time we've encountered this.
@samcunliffe samcunliffe changed the title Exclude www.gnu.org from link checker Exclude gnu.org and fsf.org from link checker Oct 1, 2024
@samcunliffe samcunliffe enabled auto-merge (squash) October 1, 2024 07:30
@samcunliffe samcunliffe added the task A task to be completed with the repo label Oct 1, 2024
Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion

# necessarily not real links - i.e. demos and to be filled by
# cookiecutter values.
args:
"--verbose --exclude https://forum.image.sc/ --exclude docs/pages
"--verbose --exclude https://forum.image.sc/ --exclude http://www.gnu.org --exclude http://fsf.org --exclude docs/pages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"--verbose --exclude https://forum.image.sc/ --exclude http://www.gnu.org --exclude http://fsf.org --exclude docs/pages
"--verbose --exclude https://forum.image.sc/ --exclude
http://www.gnu.org --exclude http://fsf.org --exclude docs/pages

@samcunliffe samcunliffe merged commit 9e59024 into main Oct 1, 2024
12 checks passed
@samcunliffe samcunliffe deleted the sc/ignore-gnu-dot-org branch October 1, 2024 10:30
@paddyroddy
Copy link
Member

@samcunliffe stop automerging like that! Otherwise, what is the point in reviewing?

@samcunliffe
Copy link
Member Author

@samcunliffe stop automerging like that! Otherwise, what is the point in reviewing?

🤖 the automerge robot and our linters are happy with my linebreaks.

@paddyroddy
Copy link
Member

🤖 the automerge robot and our linters are happy with my linebreaks.

That's because you wouldn't allow https://prettier.io/docs/en/options.html#prose-wrap

@samcunliffe
Copy link
Member Author

Did I? That doesn't sound like a think I would block...

We had it in

@samcunliffe
Copy link
Member Author

🤖 the automerge robot and our linters are happy with my linebreaks.

That's because you wouldn't allow https://prettier.io/docs/en/options.html#prose-wrap

Ha! Found it. @paddyroddy, I'm sorry to report that it was you that removed that:

@paddyroddy
Copy link
Member

Ha! Found it. @paddyroddy, I'm sorry to report that it was you that removed that:

* [Fix #361 #364](https://github.com/UCL-ARC/python-tooling/pull/364)

I'm fully aware, it was due to your markdown linking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task A task to be completed with the repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants