-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Video Panning Option #150
Open
Sodra
wants to merge
16
commits into
TypesettingTools:master
Choose a base branch
from
Sodra:video_panning_option
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Mar 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e3949cd - Browse repository at this point
Copy the full SHA e3949cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3d796a - Browse repository at this point
Copy the full SHA f3d796aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f95f76 - Browse repository at this point
Copy the full SHA 5f95f76View commit details -
Fix mouse position bug when videoAr > displayAr
Crosshair drawing is broken when videoAr != displayAr
Configuration menu - View commit details
-
Copy full SHA for 0ec0f20 - Browse repository at this point
Copy the full SHA 0ec0f20View commit details -
I'm not sure about that scale_factor, i don't know how to test that
Configuration menu - View commit details
-
Copy full SHA for 808ead6 - Browse repository at this point
Copy the full SHA 808ead6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d73dfe9 - Browse repository at this point
Copy the full SHA d73dfe9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70ddf3c - Browse repository at this point
Copy the full SHA 70ddf3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f6836d - Browse repository at this point
Copy the full SHA 4f6836dView commit details -
Configuration menu - View commit details
-
Copy full SHA for db6297c - Browse repository at this point
Copy the full SHA db6297cView commit details -
with a "good enough" implementation
Configuration menu - View commit details
-
Copy full SHA for 09ea0f5 - Browse repository at this point
Copy the full SHA 09ea0f5View commit details -
The preview window would change in width, when the video was being zoomed. Possibly, because on windows, zooming only calls UpdateSize once, but on linux, it gets called multiple, like 8 times. Rounding fixed it.
Configuration menu - View commit details
-
Copy full SHA for 14d078f - Browse repository at this point
Copy the full SHA 14d078fView commit details -
I'm not entirely sure, that this is how it's supposed to be added. This requires editing the already existing hotkey.json file (shows path in log, if it exists). Should this also be added to hotkey.cpp?
Configuration menu - View commit details
-
Copy full SHA for 0b8586e - Browse repository at this point
Copy the full SHA 0b8586eView commit details -
Revert "Add reset hotkey as Ctrl-R" / Not needed
This reverts commit 3d525d9. The default hotkey is not required. People can just add a custom one from the hotkey settings if they want this.
Configuration menu - View commit details
-
Copy full SHA for 36f7e10 - Browse repository at this point
Copy the full SHA 36f7e10View commit details
Commits on Mar 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b332181 - Browse repository at this point
Copy the full SHA b332181View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb50811 - Browse repository at this point
Copy the full SHA bb50811View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03ffce8 - Browse repository at this point
Copy the full SHA 03ffce8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.