Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-10897: disable CGO from builds #84

Merged
merged 1 commit into from
Jan 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- name: Build the CLI binary
run: |
cd mservctl
go build -o ../bin/mservctl
CGO_ENABLED=0 go build -o ../bin/mservctl
cd ..

- name: Upload ${{ runner.os }} ${{ matrix.arch }} binary
Expand Down
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ test: $(shell find . -type f -iname "*.go")
# Lint golangci lint
lint: .golangci.yaml hack/bin/golangci-lint
> mkdir -p $(@D)
> hack/bin/golangci-lint run
> CGO_ENABLED=0 hack/bin/golangci-lint run

hack/bin/golangci-lint:
> curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh \
Expand All @@ -84,12 +84,12 @@ build: mserv mservctl ## Build server and client binary.
.PHONY: build

mserv:
> go build -o bin/mserv
> CGO_ENABLED=0 go build -o bin/mserv
.PHONY: mserv

mservctl:
> cd mservctl
> go build -o ../bin/mservctl
> CGO_ENABLED=0 go build -o ../bin/mservctl
.PHONY: mservctl

start: ## Start runs development environment with mserv and mongo in docker-compose.
Expand Down
Loading