Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TT-10897: disable CGO from builds #84

Merged
merged 1 commit into from
Jan 5, 2024
Merged

TT-10897: disable CGO from builds #84

merged 1 commit into from
Jan 5, 2024

Conversation

mitjaziv
Copy link
Collaborator

@mitjaziv mitjaziv commented Jan 3, 2024 •
edited
Loading

Description

Change disables unnecessary CGO from builds.

Related Issue

TT-10897

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules dependencies have been updated; run go mod tidy in applicable directories.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • golangci-lint run

@mitjaziv mitjaziv requested a review from a team as a code owner January 3, 2024 11:32
@mitjaziv mitjaziv requested review from olamilekan000, excieve, gwotg and komuw and removed request for a team and olamilekan000 January 3, 2024 11:32
umit
umit approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@umit umit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mitjaziv mitjaziv force-pushed the TT-10897-mservct-without-cgo branch 5 times, most recently from d2a462a to c8e8ebf Compare January 5, 2024 08:37
@mitjaziv mitjaziv force-pushed the TT-10897-mservct-without-cgo branch from c8e8ebf to 522861a Compare January 5, 2024 08:49
@mitjaziv mitjaziv changed the title TT-10897: remove CGO from mservctl build TT-10897: disable CGO from builds Jan 5, 2024
@mitjaziv mitjaziv merged commit 40d390f into master Jan 5, 2024
1 check passed
@mitjaziv mitjaziv deleted the TT-10897-mservct-without-cgo branch January 5, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komuw komuw komuw approved these changes

@umit umit umit approved these changes

@excieve excieve Awaiting requested review from excieve

@gwotg gwotg Awaiting requested review from gwotg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitjaziv @umit @komuw