Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CDash URLs to builds and nonpassing tests with same base repo version #485

Merged
merged 13 commits into from
Jun 7, 2022

Commits on Jun 7, 2022

  1. Add headers for different sets of unit tests (#483)

    This is to make the file easier to navigate so I can add more unit tests.
    
    This file has gotten way too big and needs to be broken into several smaller
    files at some point here.
    bartlettroscoe committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    40b81ed View commit details
    Browse the repository at this point in the history
  2. message_wrapper() Use arg forwarding to preserve semi-colons (#483)

    This was not printing out the semi-colons in a list passed to
    message_wrapper().
    
    I noticed this while working on #483.
    bartlettroscoe committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    074ad9a View commit details
    Browse the repository at this point in the history
  3. Add function unittest_string_var_regex() (#483)

    I also updated the documentation some for unittest_string_regex().
    
    I do not run the new function unittest_string_var_regex() in this commit but
    will in a later commit where I manually tested as part of work for #483 to
    ensure it passes and fails when it should.
    bartlettroscoe committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    224a11d View commit details
    Browse the repository at this point in the history
  4. Moved arg parsing helper functions into new modules (#483)

    This makes the module TribitsGeneralMacros.cmake smaller and better aggregates
    these commands.
    
    I also added a new macro tribits_assert_parse_arg_one_value() which I just
    tested manually.  It is a very simple macro so I am not too worried about not
    unit testing it yet.
    bartlettroscoe committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    ed724f9 View commit details
    Browse the repository at this point in the history
  5. Change parse argument assert functions to accept a list of args (#483)

    This allows more compact argument parsing code and checking
    bartlettroscoe committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    b383ed2 View commit details
    Browse the repository at this point in the history
  6. Factor out functions into TribitsGitRepoVersionInfo.cmake (#483)

    We need to be breaking up TribitsGlobalMacros.cmake because it is too long.
    bartlettroscoe committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    22d618f View commit details
    Browse the repository at this point in the history
  7. Add function tribits_git_repo_sha1() (#483)

    This will be a robust way to generate the CDash URLs that contain 'Revision'
    for when the base git repos can't produce a SHA1.  And this is just a very
    generally useful function.
    bartlettroscoe committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    608570c View commit details
    Browse the repository at this point in the history
  8. Set list policy to avoid warning (#483)

    This comes up with refactorings being done for #483.
    bartlettroscoe committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    b84e791 View commit details
    Browse the repository at this point in the history
  9. Rename to TribitsGetCDashUrlsInsideCTestS.cmake (#483)

    I will be adding functions for getting more CDash URLs that for just this one
    build's results.
    bartlettroscoe committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    7e25fb2 View commit details
    Browse the repository at this point in the history
  10. Rename to tribits_print_cdash_url(), change print msg (#483)

    This is part of a refactoring to display more CDash URLs other than just build
    URLs.
    bartlettroscoe committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    b3074cc View commit details
    Browse the repository at this point in the history
  11. Factor out tribits_get_cdash_site_from_drop_site_and_location() (#483)

    This will make this easier to reuse to get other CDash URLs.
    bartlettroscoe committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    10dc684 View commit details
    Browse the repository at this point in the history
  12. Produce CDash URLs to all builds and nonpassing tests for same repo v…

    …ersion (#483)
    
    This makes it easy to click on links to these other CDash URLs to see what is
    happening with all of the builds for the same repo version.
    
    The main target is for the GitHub Actions drivers for TriBITS testing.  This
    makes it easy to get at those results.
    
    As part of this, I also renamed the function
    tribits_get_build_url_and_write_to_file() to tribits_get_cdash_build_url() and
    removed the ability to write to a file.  (We just don't need that anymore and
    it is trivial to write a string to a file.)
    bartlettroscoe committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    1738ccd View commit details
    Browse the repository at this point in the history
  13. Have 'dashboard' target set CTEST_UPDATE_VERSION_ONLY=TRUE

    This will post the base repo version info to CDash which provides more info
    right on CDash on the main index.php page.
    
    However, it will set CTEST_DO_UPDATES=OFF unless the base repo is a Git repo
    and we can extract the SHA1 from the repo with tribits_git_repo_sha1() (which
    is a very robust function).
    bartlettroscoe committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    d37ff0f View commit details
    Browse the repository at this point in the history