Add CDash URLs to builds and nonpassing tests with same base repo version #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to make the file easier to navigate so I can add more unit tests. This file has gotten way too big and needs to be broken into several smaller files at some point here.
This was not printing out the semi-colons in a list passed to message_wrapper(). I noticed this while working on #483.
I also updated the documentation some for unittest_string_regex(). I do not run the new function unittest_string_var_regex() in this commit but will in a later commit where I manually tested as part of work for #483 to ensure it passes and fails when it should.
This makes the module TribitsGeneralMacros.cmake smaller and better aggregates these commands. I also added a new macro tribits_assert_parse_arg_one_value() which I just tested manually. It is a very simple macro so I am not too worried about not unit testing it yet.
This allows more compact argument parsing code and checking
We need to be breaking up TribitsGlobalMacros.cmake because it is too long.
This will be a robust way to generate the CDash URLs that contain 'Revision' for when the base git repos can't produce a SHA1. And this is just a very generally useful function.
This comes up with refactorings being done for #483.
I will be adding functions for getting more CDash URLs that for just this one build's results.
This is part of a refactoring to display more CDash URLs other than just build URLs.
This will make this easier to reuse to get other CDash URLs.
…ersion (#483) This makes it easy to click on links to these other CDash URLs to see what is happening with all of the builds for the same repo version. The main target is for the GitHub Actions drivers for TriBITS testing. This makes it easy to get at those results. As part of this, I also renamed the function tribits_get_build_url_and_write_to_file() to tribits_get_cdash_build_url() and removed the ability to write to a file. (We just don't need that anymore and it is trivial to write a string to a file.)
This will post the base repo version info to CDash which provides more info right on CDash on the main index.php page. However, it will set CTEST_DO_UPDATES=OFF unless the base repo is a Git repo and we can extract the SHA1 from the repo with tribits_git_repo_sha1() (which is a very robust function).
bartlettroscoe
force-pushed
the
483-cdash-revision-urls
branch
from
8404366
to
d37ff0f
Compare
|
Hello @KyleFromKitware, can you please do a review of this PR? It is likely better to review this PR one-commit-at-a-time and ignore whitespace (see "Notes to Reviewers" above. Also, I would like to merge this right now and allow you to do a post-merge review (and any issues can be resolved in a follow-up PR). |
rabartlett1972
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Approving so the merge can happen but it would be good to get a post-merge review from @KyleFromKitware
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this pull request
Jun 10, 2022
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this pull request
Jun 10, 2022
It was pointed out by @KyleFromKitware in the review of PR TriBITSPub#485 that calling cmake_policy() in a function will change a policy in the calling scope. NOTE: The function() command does not create a new policy scope but does create a new variable scope. Just the opposite, include() creates a new policy scope but not a new variable scope.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this pull request
Jun 10, 2022
…iBITSPub#485) With newer CMake version, you can just quote the entire argument: "--pretty=format:<fmnt>" where <fmnt> may have spaces and everything seems to work correctly.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this pull request
Jun 10, 2022
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this pull request
Jun 10, 2022
It was pointed out by @KyleFromKitware in the review of PR TriBITSPub#485 that calling cmake_policy() in a function will change a policy in the calling scope. NOTE: The function() command does not create a new policy scope but does create a new variable scope. Just the opposite, include() creates a new policy scope but not a new variable scope.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this pull request
Jun 10, 2022
…iBITSPub#485) With newer CMake version, you can just quote the entire argument: "--pretty=format:<fmnt>" where <fmnt> may have spaces and everything seems to work correctly.
bartlettroscoe
added a commit
that referenced
this pull request
Jun 10, 2022
Address review feedback from PR #485
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add CDash URLs getting printed and written to file for the builds and non-passing tests on CDash for the same base repo Git version SHA1 (see Issue #483). For more info, see the new section Links to results on CDash.
Notes to Reviewers