Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] adding metric util and metric filter #17

Merged
merged 4 commits into from
Feb 18, 2024
Merged

[feature] adding metric util and metric filter #17

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f88e563
[feature] adding metric util and metric filters
shahryarSafizadeh Feb 18, 2024
80bf261
[revision]f88e5636
shahryarSafizadeh Feb 18, 2024
3e03cbe
[revision]f88e5636
shahryarSafizadeh Feb 18, 2024
1da8483
[revision]f88e5636
shahryarSafizadeh Feb 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions ...ring-boot-starter/src/main/java/com/tosan/http/server/starter/metrics/util/MeterUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,20 +70,20 @@ public void updateGaugeMeterByDecrementing(String metricName, Tags tags) {
}

private Meter getMeter(MeterType meterType, String meterName, String description, Tags tags) {
switch (meterType) {
case COUNTER: {
return registerCounterMeter(meterName, description, tags);
}
case TIMER: {
return registerTimerMeter(meterName, description, tags);
}
case GAUGE: {
return registerGaugeMeter(meterName, description, tags);
}
default: {
return null;
if (meterType != null) {
switch (meterType) {
case COUNTER: {
return registerCounterMeter(meterName, description, tags);
}
case TIMER: {
return registerTimerMeter(meterName, description, tags);
}
case GAUGE: {
return registerGaugeMeter(meterName, description, tags);
}
}
}
return null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error log no meter type is selected

}

private String createKey(String meterName, Tags tags) {
Expand Down