[feature] adding metric util and metric filter #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minakh1993
requested changes
Feb 18, 2024
|
|
||
| @Bean | ||
| @ConditionalOnMissingBean | ||
| @ConditionalOnProperty(value = "metric.util.enable", havingValue = "true") |
There was a problem hiding this comment.
util doesn't need enable disable
| http.log.format=json | ||
|
|
||
| meter.util.enable=true |
There was a problem hiding this comment.
this property is not needed meter.util.enable=true
| @ConditionalOnMissingBean | ||
| @ConditionalOnProperty(value = "metric.filter.enable", havingValue = "true") | ||
| public MeterFilter meterFilter(MeterFilterConfig meterFilterConfig) { | ||
| return new MeterFilter() { |
There was a problem hiding this comment.
defining anonymous class here is not appropriate
| * @since 2/13/2024 | ||
| */ | ||
| public class GaugeValue { | ||
| private int value = 0; |
| @Validated | ||
| public class MeterFilterConfig { | ||
|
|
||
| private String[] filteredMeterNames; |
There was a problem hiding this comment.
using excluded in parameter names ?
| } | ||
| gaugeMeters.put(createKey(metricName, tags), gaugeValue); | ||
| return gauge; | ||
| } |
minakh1993
reviewed
Feb 18, 2024
| } | ||
| } | ||
| return null; |
There was a problem hiding this comment.
error log no meter type is selected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRD-221992