Add Curvature to GridObject #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge main into dev
wkearn
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Looks pretty good, @Teschl!
Notes for future reference: Curvature is numerically unstable and very sensitive both to the data and to numerical errors. There are numerical differences between this implementation and the MATLAB one especially when the denominator of the calculation is close to zero (i.e. when the gradient is zero). We should be careful about making comparisons between the two. The MATLAB implementation sets the curvature to zero when the denominator is exactly zero. This implementation instead adds a small offset to the denominator.
This was referenced Dec 9, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the curvature function to the
GridObject. Potential issue with the use of an epsilon to avoid divisions by zero, since the Matlab version does not have this. (This branch has a lot of commits since I used it before to locally test the curvature function written in C)