Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filter function to GridObject #107

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Add filter function to GridObject #107

merged 5 commits into from
Dec 10, 2024

Conversation

Teschl
Copy link
Contributor

@Teschl Teschl commented Dec 7, 2024 •
edited
Loading

This pull request adds the filter function to the GridObject.

closes #103

@wkearn
Copy link
Contributor

wkearn commented Dec 9, 2024

Merging #100 created a few merge conflicts here.

wkearn
wkearn requested changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@wkearn wkearn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There is just the issue with the Bessel correction to fix.

src/topotoolbox/grid_object.py Show resolved Hide resolved
src/topotoolbox/grid_object.py Show resolved Hide resolved
@Teschl
Copy link
Contributor Author

Teschl commented Dec 9, 2024

I fixed the issue with the std method. Should be ready to be merged. @wkearn

@wkearn wkearn merged commit df1c307 into TopoToolbox:main Dec 10, 2024
7 checks passed
@Teschl Teschl deleted the filter branch December 12, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkearn wkearn wkearn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add filter() function to the GridObject
2 participants
@Teschl @wkearn