Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Flaky add submission test (round 2) #3948

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Fix: Flaky add submission test (round 2) #3948

merged 1 commit into from
Jul 10, 2023

Conversation

KevinMulhern
Copy link
Member

Because:

This commit:

  • Wait until the turbo frame is finished loading and then open the submission modal.

@KevinMulhern
Fix: Flaky add submission test (round 2)
d4ab941 
Because:
* Capybara is trying to open the form before the project submissions turbo frame is finished loading.

This commit:
* Wait until the turbo frame is finished loading and then open the submission modal.
@KevinMulhern KevinMulhern self-assigned this Jul 10, 2023
@KevinMulhern KevinMulhern added the Type: Bug Involves something that isn't working as intended label Jul 10, 2023
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-3948 July 10, 2023 18:49 Inactive
@ChargrilledChook ChargrilledChook mentioned this pull request Jul 10, 2023
Merged
@KevinMulhern KevinMulhern merged commit 6b522ee into main Jul 10, 2023
2 checks passed
@KevinMulhern KevinMulhern deleted the chore/add-submission-flaky-test-round-2 branch July 10, 2023 23:06
@ChargrilledChook
Copy link
Member

ChargrilledChook commented Jul 10, 2023 •
edited
Loading

@KevinMulhern Still failing for me locally 😢
image

and a new failure I haven't seen before
image

@KevinMulhern
Copy link
Member Author

I've been able to recreate it a couple of times with the old 30.times do wrapped around that test trick lol. The screenshot doesn't show the modal. But that doesn't make any sense because the fill in steps are working fine - the modal can't close without submitting or cancelling.

I've got one more idea in me before I resort to sticking a sleep in there or putting that test into pending lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CouchofTomato CouchofTomato CouchofTomato approved these changes

@ChargrilledChook ChargrilledChook ChargrilledChook approved these changes

Assignees

@KevinMulhern KevinMulhern

Labels
Type: Bug Involves something that isn't working as intended
Projects
Main Site
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinMulhern @ChargrilledChook @CouchofTomato