Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Improve theme switcher UX (#3497) #3844

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Fix: Improve theme switcher UX (#3497) #3844

merged 1 commit into from
Jul 11, 2023
+11 −15

Conversation

ChargrilledChook
Copy link
Member

Because:

  • Current behaviour is inconsistent and confusing

This PR:

  • Moves theme switcher out of dropdown menu when logged in
  • Adjusts position to be consistent when logged in or out
  • Tidy broken Lookbook previews due to removal of GA tracking

@ChargrilledChook ChargrilledChook added the create-review-app Create a Heroku review app for pull request label Jun 12, 2023
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-3844 June 12, 2023 02:28 Inactive
@ChargrilledChook ChargrilledChook removed the create-review-app Create a Heroku review app for pull request label Jun 12, 2023
KevinMulhern
KevinMulhern requested changes Jun 14, 2023
View reviewed changes
Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of styling tweaks to make it consistent with the other nav items:

The base styling here needs its group hover updated to

dark:group-hover:text-gray-300

And the icon only styling here needs updated to:

 icon_only: 'text-gray-400'

@ChargrilledChook
Copy link
Member Author

@KevinMulhern Done ✔️

@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-3844 June 18, 2023 03:07 Inactive
@KevinMulhern KevinMulhern added the create-review-app Create a Heroku review app for pull request label Jun 19, 2023
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-3844 June 19, 2023 09:41 Inactive
@ChargrilledChook
Copy link
Member Author

Need to fix a spec; something has regressed after some other recent merges

@KevinMulhern
Copy link
Member

My bad @ChargrilledChook, looks like a flaky test I've introduced. This should be the fix

@Asartea Asartea mentioned this pull request Jul 8, 2023
Merged
7 tasks
@ChargrilledChook
Copy link
Member Author

Should be fine once #3948 is merged

@ChargrilledChook
Fix: Improve theme switcher UX (#3497)
7e152d1 
Because:
* Current behaviour is inconsistent and confusing

This PR:
* Moves theme switcher out of dropdown menu when logged in
* Adjusts position to be consistent when logged in or out
* Tidy broken Lookbook previews due to removal of GA tracking
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-3844 July 10, 2023 23:26 Inactive
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-3844 July 11, 2023 01:16 Inactive
KevinMulhern
KevinMulhern approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ChargrilledChook ChargrilledChook merged commit bb119ff into main Jul 11, 2023
@ChargrilledChook ChargrilledChook deleted the fix/improve-theme-switcher-ux branch July 11, 2023 03:00
@ChargrilledChook ChargrilledChook mentioned this pull request Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinMulhern KevinMulhern KevinMulhern approved these changes

Assignees
No one assigned
Labels
create-review-app Create a Heroku review app for pull request
Projects
Main Site
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChargrilledChook @KevinMulhern