Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Update wording of our beliefs #3922

Merged
merged 7 commits into from
Jul 11, 2023
Merged

Feature: Update wording of our beliefs #3922

merged 7 commits into from
Jul 11, 2023

Conversation

rlmoser99
Copy link
Member

@rlmoser99 rlmoser99 commented Jul 7, 2023

I noticed the wording of the "Motivation is fueled by working with others" was not quite accurate. It was suggested to reword these into more of a "How it works" section.

This PR

  • Renames the beliefs section to "What you can expect at The Odin Project"'
  • Reword each section to encompass similar things that we value and want our learners to be aware of.

Issue

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
  • Feature - adds new or amends existing user-facing behavior
  • Chore - changes that have no user-facing value, refactors, dependency bumps, etc
  • Fix - bug fixes
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • I have verified all tests and linters pass after making these changes.
  • If this PR addresses an open issue, it is linked in the Issue section
  • If applicable, this PR includes new or updated automated tests

@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-3922 July 7, 2023 02:07 Inactive
@KevinMulhern KevinMulhern self-requested a review July 8, 2023 16:53
Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @rlmoser99 , this was badly in need of an update 💪

I think the new content may be leaning a little too much towards how users should use TOP. Tweaking it a little to highlight TOP's best qualities may be better for this pages intended audience - new visitors trying to figure out if this TOP thing for them. It's pretty much a marketing page where we'll have to sell TOP to visitors and thats the kind of language we're best to use.

I've left a few suggestions of how we could maybe do that, mostly half baked ideas though lol. Just wanted to give you an idea of what I'm getting at.

config/locales/en.yml Outdated Show resolved Hide resolved
config/locales/en.yml Outdated Show resolved Hide resolved
@@ -10,7 +10,7 @@
</p>
</div>

<h2 class="text-center text-gray-700 dark:text-gray-300 text-2xl mb-12">Our Beliefs</h2>
<h2 class="text-center text-gray-700 dark:text-gray-300 text-2xl mb-12">What you can expect at The Odin Project</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

config/locales/en.yml Outdated Show resolved Hide resolved
config/locales/en.yml Outdated Show resolved Hide resolved
@rlmoser99
Copy link
Member Author

I am going to play around with the wording of the first point and maybe last point.

@rlmoser99
Copy link
Member Author

The test that is failing is passing locally and has nothing to do with these changes. 🤔

@Asartea
Copy link
Contributor

Asartea commented Jul 8, 2023

@rlmoser99 see #3844 (comment) and #3924 ; one of the recent changes made that test flaky

Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @rlmoser99, nice work! 💪

Sorry, I feel like I only half explained myself the other day lol. Most of the users who land on this page are from search engines:

Screenshot 2023-07-10 at 20 52 45

They'll understandably to be looking to find out what they can gain from TOP as quickly as possible after clicking on the search result. This new content will communicate that better than "our beliefs" ever could 🎉

@rlmoser99 rlmoser99 merged commit 8de236f into main Jul 11, 2023
@rlmoser99 rlmoser99 deleted the fix/reword-beliefs branch July 11, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants