-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Update wording of our beliefs #3922
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @rlmoser99 , this was badly in need of an update 💪
I think the new content may be leaning a little too much towards how users should use TOP. Tweaking it a little to highlight TOP's best qualities may be better for this pages intended audience - new visitors trying to figure out if this TOP thing for them. It's pretty much a marketing page where we'll have to sell TOP to visitors and thats the kind of language we're best to use.
I've left a few suggestions of how we could maybe do that, mostly half baked ideas though lol. Just wanted to give you an idea of what I'm getting at.
@@ -10,7 +10,7 @@ | |||
</p> | |||
</div> | |||
|
|||
<h2 class="text-center text-gray-700 dark:text-gray-300 text-2xl mb-12">Our Beliefs</h2> | |||
<h2 class="text-center text-gray-700 dark:text-gray-300 text-2xl mb-12">What you can expect at The Odin Project</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Co-authored-by: Kevin Mulhern <[email protected]>
Co-authored-by: Kevin Mulhern <[email protected]>
Co-authored-by: Kevin Mulhern <[email protected]>
Co-authored-by: Kevin Mulhern <[email protected]>
I am going to play around with the wording of the first point and maybe last point. |
The test that is failing is passing locally and has nothing to do with these changes. 🤔 |
@rlmoser99 see #3844 (comment) and #3924 ; one of the recent changes made that test flaky |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @rlmoser99, nice work! 💪
Sorry, I feel like I only half explained myself the other day lol. Most of the users who land on this page are from search engines:
They'll understandably to be looking to find out what they can gain from TOP as quickly as possible after clicking on the search result. This new content will communicate that better than "our beliefs" ever could 🎉
I noticed the wording of the "Motivation is fueled by working with others" was not quite accurate. It was suggested to reword these into more of a "How it works" section.
This PR
Issue
Additional Information
Pull Request Requirements
keyword: brief description of change
format, using one of the following keywords:Feature
- adds new or amends existing user-facing behaviorChore
- changes that have no user-facing value, refactors, dependency bumps, etcFix
- bug fixesBecause
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section