fix(core): reset culler state after read pixels failed

ThatOpen · Aug 28, 2024 · bded3c3 · bded3c3
1 parent fdacb77
commit bded3c3
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@thatopen/components",
   "description": "Collection of core functionalities to author BIM apps.",
-  "version": "2.2.7",
+  "version": "2.2.8",
   "author": "That Open Company",
   "contributors": [
     "Antonio Gonzalez Viegas (https://github.com/agviegas)",

diff --git a/packages/core/src/core/Components/index.ts b/packages/core/src/core/Components/index.ts
@@ -14,7 +14,7 @@ export class Components implements Disposable {
   /**
    * The version of the @thatopen/components library.
    */
-  static readonly release = "2.2.7";
+  static readonly release = "2.2.8";
 
   /** {@link Disposable.onDisposed} */
   readonly onDisposed = new Event<void>();

diff --git a/packages/core/src/core/Cullers/src/culler-renderer.ts b/packages/core/src/core/Cullers/src/culler-renderer.ts
@@ -189,6 +189,8 @@ export class CullerRenderer {
       );
     } catch (e) {
       // Pixels couldn't be read, possibly because culler was disposed
+      this.needsUpdate = false;
+      this._isWorkerBusy = false;
       this.renderer.setRenderTarget(null);
       return;
     }

diff --git a/packages/core/src/core/ShadowedScene/src/distance-renderer.ts b/packages/core/src/core/ShadowedScene/src/distance-renderer.ts
@@ -255,6 +255,7 @@ void main() {
     } catch (e) {
       // Pixels couldn't be read, possibly because culler was disposed
       this.renderer.setRenderTarget(null);
+      this._isWorkerBusy = false;
       return;
     }