fix(core): add guard for cullers pixel reading

ThatOpen · Aug 28, 2024 · fdacb77 · fdacb77
1 parent 5052f9d
commit fdacb77
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 22 deletions.
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@thatopen/components",
   "description": "Collection of core functionalities to author BIM apps.",
-  "version": "2.2.6",
+  "version": "2.2.7",
   "author": "That Open Company",
   "contributors": [
     "Antonio Gonzalez Viegas (https://github.com/agviegas)",

diff --git a/packages/core/src/core/Components/index.ts b/packages/core/src/core/Components/index.ts
@@ -14,7 +14,7 @@ export class Components implements Disposable {
   /**
    * The version of the @thatopen/components library.
    */
-  static readonly release = "2.2.6";
+  static readonly release = "2.2.7";
 
   /** {@link Disposable.onDisposed} */
   readonly onDisposed = new Event<void>();

diff --git a/packages/core/src/core/Cullers/src/culler-renderer.ts b/packages/core/src/core/Cullers/src/culler-renderer.ts
@@ -175,16 +175,23 @@ export class CullerRenderer {
     this.renderer.render(this.scene, camera);
 
     const context = this.renderer.getContext() as WebGL2RenderingContext;
-    await readPixelsAsync(
-      context,
-      0,
-      0,
-      this._width,
-      this._height,
-      context.RGBA,
-      context.UNSIGNED_BYTE,
-      this._buffer,
-    );
+
+    try {
+      await readPixelsAsync(
+        context,
+        0,
+        0,
+        this._width,
+        this._height,
+        context.RGBA,
+        context.UNSIGNED_BYTE,
+        this._buffer,
+      );
+    } catch (e) {
+      // Pixels couldn't be read, possibly because culler was disposed
+      this.renderer.setRenderTarget(null);
+      return;
+    }
 
     this.renderer.setRenderTarget(null);
 

diff --git a/packages/core/src/core/ShadowedScene/src/distance-renderer.ts b/packages/core/src/core/ShadowedScene/src/distance-renderer.ts
@@ -240,16 +240,23 @@ void main() {
     this.renderer.render(this.scene, this.camera);
 
     const context = this.renderer.getContext() as WebGL2RenderingContext;
-    await readPixelsAsync(
-      context,
-      0,
-      0,
-      this._width,
-      this._height,
-      context.RGBA,
-      context.UNSIGNED_BYTE,
-      this._buffer,
-    );
+
+    try {
+      await readPixelsAsync(
+        context,
+        0,
+        0,
+        this._width,
+        this._height,
+        context.RGBA,
+        context.UNSIGNED_BYTE,
+        this._buffer,
+      );
+    } catch (e) {
+      // Pixels couldn't be read, possibly because culler was disposed
+      this.renderer.setRenderTarget(null);
+      return;
+    }
 
     this.renderer.setRenderTarget(null);