Movies Sofie #67
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,22 @@ | ||
| import { BrowserRouter, Routes, Route } from 'react-router-dom' | ||
| import { useParams } from 'react-router-dom' | ||
| import { Movies } from './components/FirstPage.jsx' | ||
| import { Details } from './components/SecondPage.jsx' | ||
| import { Nav } from './components/Nav' | ||
| import { useEffect, useState } from 'react' | ||
| import { NotFound } from './components/NotFound.jsx' | ||
|
|
||
| export const App = () => { | ||
| return ( | ||
| <BrowserRouter> | ||
| <main> | ||
| {/* <Nav /> */} | ||
| <Routes> | ||
| <Route path="/" element={<Movies />} /> | ||
| <Route path="/details/:slug" element={<Details />} /> | ||
| <Route path="/notfound/" element={<NotFound />} /> | ||
| </Routes> | ||
| </main> | ||
| </BrowserRouter> | ||
| ) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import Lottie from 'react-lottie' | ||
| import animationData from '../lotties/backanimation.json' | ||
|
|
||
| export const BackImage = () => { | ||
| const defaultOptions = { | ||
| loop: true, | ||
| autoplay: true, | ||
| animationData: animationData, | ||
| rendererSettings: { | ||
| preserveAspectRatio: 'xMidYMid slice', | ||
| }, | ||
| } | ||
|
|
||
| return ( | ||
| <div> | ||
| <Lottie | ||
| options={defaultOptions} | ||
| height={200} | ||
| width={200} | ||
| /> | ||
| </div> | ||
| ) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import { Link } from 'react-router-dom' | ||
| import '../styling/DetailList.css' | ||
| import { BackImage } from './BackImage' | ||
|
|
||
| export const DetailList = ({ detailData }) => { | ||
| console.log('check data in DetailList', detailData) | ||
| return ( | ||
| <> | ||
| {/* {detailData && | ||
| detailData.results.map((detail) => ( */} | ||
| <div className="detail-wrapper"> | ||
| <div | ||
| className="detail-background" | ||
| style={{ | ||
| backgroundImage: `url(https://media.themoviedb.org/t/p/w780${detailData.backdrop_path})`, | ||
| backgroundRepeat: 'no-repeat', | ||
| backgroundSize: 'cover', | ||
| minWidth: '100VW', | ||
| }}> | ||
| <div className="details-card"> | ||
| <Link to={'/'}> | ||
| <BackImage className="back-btn" /> | ||
| </Link> | ||
| <img | ||
| className="poster-image" | ||
| src={`https://image.tmdb.org/t/p/w342${detailData.poster_path}`} | ||
| alt={`Movie poster for ${detailData.title}`} | ||
| /> | ||
| <div className="poster-text"> | ||
| <h1>{detailData.title}</h1> | ||
| <h2>⭐ {detailData.vote_average.toFixed(1)}</h2> | ||
| <p>{detailData.overview}</p> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </> | ||
| ) | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import { useState, useEffect } from 'react' | ||
| import { PopularList } from './PopularList.jsx' | ||
| import { Loader } from './Loader' | ||
|
|
||
| export const Movies = () => { | ||
| const [movieData, setMovieData] = useState(null) | ||
| const [isLoading, setIsLoading] = useState(true) | ||
|
|
||
| const BASE_URL = 'https://api.themoviedb.org/3/movie/' | ||
| const API_KEY = '23ace2b0c27910f5cec13f5bdb014044' | ||
| // const urlMovies = `${BASE_URL}popular?api_key=${API_KEY}&language=en-US&page=1` | ||
|
|
||
| const testUrl = | ||
| 'https://api.themoviedb.org/3/movie/popular?api_key=23ace2b0c27910f5cec13f5bdb014044&language=en-US&page=1' | ||
|
|
||
| useEffect(() => { | ||
| fetch(testUrl) | ||
| .then((result) => result.json()) | ||
| .then((json) => { | ||
| setMovieData(json) | ||
| setIsLoading(false) | ||
| }) | ||
| .catch((error) => { | ||
| console.error(error) | ||
| }) | ||
| }, [testUrl]) | ||
| console.log('moviedata firstpage', movieData) | ||
| return ( | ||
| <> | ||
| {isLoading && <Loader />} | ||
| <PopularList movieData={movieData} /> | ||
| </> | ||
| ) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| export const Images = ({ url, altText }) => { | ||
| return ( | ||
| <img className="images" src="" | ||
| ) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import Lottie from 'react-lottie' | ||
| import animationData from '../lotties/animation.json' | ||
|
|
||
| export const Loader = () => { | ||
|
|
||
|
|
||
| const defaultOptions = { | ||
| loop: true, | ||
| autoplay: true, | ||
| animationData: animationData, | ||
| rendererSettings: { | ||
| preserveAspectRatio: 'xMidYMid slice', | ||
| }, | ||
| } | ||
|
|
||
| return ( | ||
| <div> | ||
| <Lottie options={defaultOptions} height={300} width={300} /> | ||
| </div> | ||
| ) | ||
| } | ||
|
|
||
| //nedan är försök att få animationen att visas längre. | ||
|
|
||
| // useEffect(() => { | ||
| // export const DelayLottie = setTimeout(() => { | ||
|
There was a problem hiding this comment. For the next time you might want to consider creating the function "DelayLottie" before (for example, around line 5) and then you can call the function inside of the useEffect. 👍 |
||
| // setLoading(true) | ||
| // }, 3000) | ||
| // }) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import React from 'react' | ||
| import { Link, NavLink } from 'react-router-dom' | ||
| import '../styling/Nav.css' | ||
|
|
||
| export const Nav = () => { | ||
| return ( | ||
| <> | ||
| <div className="navbar-title"> | ||
| <h1>RomComs</h1> | ||
| </div> | ||
| <ul className="navbar"> | ||
| <li> | ||
| <NavLink to="/">Movies</NavLink> | ||
| </li> | ||
| <li> | ||
| <NavLink to="/details">Details</NavLink> | ||
| </li> | ||
| </ul> | ||
| </> | ||
| ) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| export const NotFound = () => { | ||
| return ( | ||
| <div>Page not found</div> | ||
| ) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import '../styling/PopularList.css' | ||
| import { Link } from 'react-router-dom' | ||
|
|
||
| //functional component | ||
| export const PopularList = ({ movieData }) => { | ||
| console.log('moviedata popularLIst', movieData) | ||
|
|
||
| return ( | ||
| <div className="movie-wrapper"> | ||
| <div className="movie-list"> | ||
| {movieData && | ||
| movieData.results.map((movie) => ( | ||
| <Link key={movie.id} to={`/details/${movie.id}`}> | ||
| <div className="movie-card" key={movie.id}> | ||
| <div className="hover-text"> | ||
| <h1 className="title">{movie.title}</h1> | ||
| <h2 className="release-date"> | ||
| Released {movie.release_date} | ||
| </h2> | ||
| </div> | ||
| <div className="poster"> | ||
| <img | ||
| className="movie-image" | ||
| src={`https://image.tmdb.org/t/p/w342${movie.poster_path}`} | ||
| alt={`Movie poster for ${movie.title}`} | ||
| /> | ||
| </div> | ||
| </div> | ||
| </Link> | ||
|
There was a problem hiding this comment. Code looks great but it gets a bit complicated to read due to the unorganised set up. |
||
| ))} | ||
| </div> | ||
| </div> | ||
| ) | ||
| } | ||
|
|
||
|
|
||
|
|
||
| // return ( | ||
| // <> | ||
| // {jsonMovies.map((movie) => ( | ||
| // <article className="movie-card" key={movie.id}> | ||
| // <Link to={`/details/${movie.id}`}></Link> | ||
| // </article> | ||
| // ))} | ||
| // </> | ||
| // ) | ||
| // } | ||
|
There was a problem hiding this comment. It is interesting how you split in two different components the fetching and the data rendering. Maybe you can explain us why you choose that logic 😊. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import '../styling/SecondPage.css' | ||
| import { useState, useEffect } from 'react' | ||
| import { Loader } from './Loader' | ||
| import {NotFound} from './NotFound' | ||
| import {Link, useParams} from 'react-router-dom' | ||
| import { DetailList } from './DetailList' | ||
|
|
||
| export const Details = () => { | ||
| const [detailData, setDetailData] = useState(null) | ||
| const [isLoading, setIsLoading] = useState(true) | ||
|
|
||
| const params = useParams() | ||
| const movieId = params.slug | ||
| const API_KEY = '23ace2b0c27910f5cec13f5bdb014044' | ||
|
|
||
| const listUrl = | ||
| `https://api.themoviedb.org/3/movie/${movieId}?api_key=${API_KEY}&language=en-US` | ||
|
|
||
| useEffect(() => { | ||
| fetch(listUrl) | ||
| .then((result) => result.json()) | ||
| .then((json) => { | ||
| setDetailData(json) | ||
| setIsLoading(false) | ||
| }) | ||
| .catch((error) => { | ||
| console.error(error) | ||
| }) | ||
| }, [listUrl]) | ||
|
|
||
| if (!detailData || detailData === undefined) { | ||
| return <Loader /> | ||
| } | ||
|
|
||
| if (detailData.success === false) { | ||
| return <NotFound /> | ||
| } | ||
| console.log('detailtdata secondpage', detailData) | ||
| return ( | ||
| <> | ||
| {isLoading && <Loader />} | ||
| <DetailList detailData={detailData} /> | ||
| </> | ||
| ) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are screens that are bigger than 780; maybe next time you could consider on taking 1280px for background images.
-Izabel&Etna