Movies Sofie #67
Movies Sofie #67
Conversation
|
Can you share a link to your deployed site? 😇 |
| <div | ||
| className="detail-background" | ||
| style={{ | ||
| backgroundImage: `url(https://media.themoviedb.org/t/p/w780${detailData.backdrop_path})`, |
There was a problem hiding this comment.
Since there are screens that are bigger than 780; maybe next time you could consider on taking 1280px for background images.
-Izabel&Etna
| //nedan är försök att få animationen att visas längre. | ||
|
|
||
| // useEffect(() => { | ||
| // export const DelayLottie = setTimeout(() => { |
There was a problem hiding this comment.
For the next time you might want to consider creating the function "DelayLottie" before (for example, around line 5) and then you can call the function inside of the useEffect. 👍
-Izabel&Etna
src/components/PopularList.jsx
Outdated
| /> | ||
| </div> | ||
| </div> | ||
| </Link> |
There was a problem hiding this comment.
Code looks great but it gets a bit complicated to read due to the unorganised set up.
-Izabel&Etna
src/components/SecondPage.jsx
Outdated
There was a problem hiding this comment.
It is interesting how you split in two different components the fetching and the data rendering. Maybe you can explain us why you choose that logic 😊.
-Izabel&Etna
src/styling/PopularList.css
Outdated
| .movie-wrapper { | ||
| display: flex; | ||
| flex-wrap: wrap; | ||
| justify-content: flex-end; |
There was a problem hiding this comment.
Just a question here...Did you want to present the movies all the way to right? or you want them to be center?
-Izabel&Etna
yaout and made it easier to read text by creating hover effect
There was a problem hiding this comment.
Please check:
- accessibility: needs to score at least 95
- how to deploy routes
Hi Antonella! |
https://bucolic-kangaroo-37b00f.netlify.app/