Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] 코스 상세 뷰 앰플리튜드 트래킹 이벤트 코드 심기 #264

Merged
merged 9 commits into from
Sep 30, 2024
Merged

[feat] 코스 상세 뷰 앰플리튜드 트래킹 이벤트 코드 심기 #264

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c364180
[feat] #263 코스 상세 앰플리튜드 이벤트, 프로퍼티 명 상수화
t1nm1ksun Sep 17, 2024
4199de0
[feat] #263 코스 상세 앰플리튜드 트래킹 코드 심기
t1nm1ksun Sep 17, 2024
49dbac9
[chore] #263 서버통신 성공시 업데이트
t1nm1ksun Sep 29, 2024
084f436
[chore] #263 uiState.courseDetail 반복 -> with 문 사용
t1nm1ksun Sep 29, 2024
517426c
[chore] #263 named parameter 사용
t1nm1ksun Sep 29, 2024
6e462ea
[chore] #263 state 이름 변경
t1nm1ksun Sep 29, 2024
a5b8a4c
[chore] #263 좋아요, 좋아요 해제 앰플 로직 수정
t1nm1ksun Sep 30, 2024
7e2ac25
Merge remote-tracking branch 'refs/remotes/origin/develop' into feat-…
t1nm1ksun Sep 30, 2024
b212fff
[chore] #263 ktlintFormat
t1nm1ksun Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/src/main/java/org/sopt/dateroad/presentation/ui/coursedetail/CourseDetailContract.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ class CourseDetailContract {
val currentImagePage: Int = 0,
val usePointLoadState: LoadState = LoadState.Idle,
val deleteLoadState: LoadState = LoadState.Idle,
var isWebViewOpened: Boolean = false
var isWebViewOpened: Boolean = false,
var hasDialogOpened: Boolean = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hasPointReadDialogOpened 이런 식으로 무슨 다이얼로그인지 명시해주면 좋을 듯,,
요거 이 방법밖에 없겠죠? ㅜ 마땅한 게 안 떠오르넹

) : UiState

sealed interface CourseDetailSideEffect : UiSideEffect {
Expand Down
33 changes: 32 additions & 1 deletion app/src/main/java/org/sopt/dateroad/presentation/ui/coursedetail/CourseDetailScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,16 @@ import org.sopt.dateroad.presentation.ui.coursedetail.component.CourseDetailBasi
import org.sopt.dateroad.presentation.ui.coursedetail.component.CourseDetailBottomBar
import org.sopt.dateroad.presentation.ui.coursedetail.component.CourseDetailUnopenedDetail
import org.sopt.dateroad.presentation.ui.coursedetail.component.courseDetailOpenedDetail
import org.sopt.dateroad.presentation.util.CourseDetailAmplitude.CLICK_COURSE_BACK
import org.sopt.dateroad.presentation.util.CourseDetailAmplitude.CLICK_COURSE_LIKES
import org.sopt.dateroad.presentation.util.CourseDetailAmplitude.CLICK_COURSE_PURCHASE
import org.sopt.dateroad.presentation.util.CourseDetailAmplitude.COURSE_LIST_ID
import org.sopt.dateroad.presentation.util.CourseDetailAmplitude.COURSE_LIST_LIKE
import org.sopt.dateroad.presentation.util.CourseDetailAmplitude.COURSE_LIST_TITLE
import org.sopt.dateroad.presentation.util.CourseDetailAmplitude.PURCHASE_SUCCESS
import org.sopt.dateroad.presentation.util.CourseDetailAmplitude.VIEW_COURSE_DETAILS
import org.sopt.dateroad.presentation.util.WebViewUrl.REPORT_URL
import org.sopt.dateroad.presentation.util.amplitude.AmplitudeUtils
import org.sopt.dateroad.presentation.util.view.LoadState
import org.sopt.dateroad.ui.theme.DATEROADTheme
import org.sopt.dateroad.ui.theme.DateRoadTheme
Expand Down Expand Up @@ -74,6 +83,18 @@ fun CourseDetailRoute(
viewModel.fetchCourseDetail(courseId = courseId)
}

LaunchedEffect(uiState.loadState, lifecycleOwner) {
if (uiState.loadState == LoadState.Success) {
AmplitudeUtils.trackEventWithProperties(
eventName = VIEW_COURSE_DETAILS,
mapOf(
COURSE_LIST_ID to uiState.courseDetail.courseId,
COURSE_LIST_TITLE to uiState.courseDetail.title
)
)
}
}
t1nm1ksun marked this conversation as resolved.
Show resolved Hide resolved

when (uiState.loadState) {
LoadState.Idle -> DateRoadIdleView()

Expand Down Expand Up @@ -101,6 +122,7 @@ fun CourseDetailRoute(
true -> viewModel.deleteCourseLike(courseId = courseId)
false -> viewModel.postCourseLike(courseId = courseId)
}
AmplitudeUtils.trackEventWithProperty(eventName = CLICK_COURSE_LIKES, propertyName = COURSE_LIST_LIKE, propertyValue = uiState.courseDetail.isUserLiked)
t1nm1ksun marked this conversation as resolved.
Show resolved Hide resolved
},
onDeleteButtonClicked = {
viewModel.deleteCourse(courseId = courseId)
Expand All @@ -110,7 +132,16 @@ fun CourseDetailRoute(
onReportCourseBottomSheet = { viewModel.setEvent(CourseDetailContract.CourseDetailEvent.OnReportCourseBottomSheet) },
dismissReportCourseBottomSheet = { viewModel.setEvent(CourseDetailContract.CourseDetailEvent.DismissReportCourseBottomSheet) },
enrollSchedule = { viewModel.setSideEffect(CourseDetailContract.CourseDetailSideEffect.NavigateToEnroll(EnrollType.TIMELINE, courseId)) },
onTopBarIconClicked = { viewModel.setSideEffect(CourseDetailContract.CourseDetailSideEffect.PopBackStack) },
onTopBarIconClicked = {
viewModel.setSideEffect(CourseDetailContract.CourseDetailSideEffect.PopBackStack)
AmplitudeUtils.trackEventWithProperties(
eventName = CLICK_COURSE_BACK,
mapOf(
t1nm1ksun marked this conversation as resolved.
Show resolved Hide resolved
CLICK_COURSE_PURCHASE to uiState.hasDialogOpened,
PURCHASE_SUCCESS to uiState.courseDetail.isAccess
)
)
},
openCourseDetail = { viewModel.postUsePoint(courseId = courseId) },
onReportButtonClicked = {
viewModel.setEvent(CourseDetailContract.CourseDetailEvent.OnReportWebViewClicked)
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/org/sopt/dateroad/presentation/ui/coursedetail/CourseDetailViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class CourseDetailViewModel @Inject constructor(
is CourseDetailContract.CourseDetailEvent.DismissDialogDeleteCourse -> setState { copy(isDeleteCourseDialogOpen = false) }
is CourseDetailContract.CourseDetailEvent.OnDialogReportCourse -> setState { copy(isReportCourseDialogOpen = true) }
is CourseDetailContract.CourseDetailEvent.DismissDialogReportCourse -> setState { copy(isReportCourseDialogOpen = false) }
is CourseDetailContract.CourseDetailEvent.OnDialogLookedByPoint -> setState { copy(isPointReadDialogOpen = true) }
is CourseDetailContract.CourseDetailEvent.OnDialogLookedByPoint -> setState { copy(isPointReadDialogOpen = true, hasDialogOpened = true) }
is CourseDetailContract.CourseDetailEvent.DismissDialogLookedByPoint -> setState { copy(isPointReadDialogOpen = false) }
is CourseDetailContract.CourseDetailEvent.OnLikeButtonClicked -> setState { copy(isLikedButtonChecked = !isLikedButtonChecked) }
is CourseDetailContract.CourseDetailEvent.OnDeleteCourseBottomSheet -> setState { copy(isDeleteCourseBottomSheetOpen = true) }
Expand Down
12 changes: 12 additions & 0 deletions app/src/main/java/org/sopt/dateroad/presentation/util/Constraints.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ object Token {
object Time {
const val TIME = " 시간"
}

object LoadingView {
const val LOTTIE = "loading.json"
const val CLIPMIN = 0
Expand All @@ -59,3 +60,14 @@ object Pattern {
private const val NICKNAME_PATTERN = "^[ㄱ-ㅎ가-힣a-zA-Z0-9]*$"
val NICKNAME_REGEX = Regex(NICKNAME_PATTERN)
}

object CourseDetailAmplitude {
const val VIEW_COURSE_DETAILS = "view_course_details"
const val CLICK_COURSE_BACK = "click_course_back"
const val CLICK_COURSE_LIKES = "click_course_likes"
const val COURSE_LIST_ID = "course_list_id"
const val COURSE_LIST_TITLE = "course_list_title"
const val CLICK_COURSE_PURCHASE = "click_course_purchase"
const val PURCHASE_SUCCESS = "purchase_success"
const val COURSE_LIST_LIKE = "course_list_like"
}
Loading