[feat] 코스 상세 뷰 앰플리튜드 트래킹 이벤트 코드 심기 #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihyunniiii
reviewed
Sep 17, 2024
app/src/main/java/org/sopt/dateroad/presentation/ui/coursedetail/CourseDetailScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/presentation/ui/coursedetail/CourseDetailScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/presentation/ui/coursedetail/CourseDetailScreen.kt
Outdated
Show resolved
Hide resolved
| @@ -23,7 +23,8 @@ class CourseDetailContract { | |||
| val currentImagePage: Int = 0, | |||
| val usePointLoadState: LoadState = LoadState.Idle, | |||
| val deleteLoadState: LoadState = LoadState.Idle, | |||
| var isWebViewOpened: Boolean = false | |||
| var isWebViewOpened: Boolean = false, | |||
| var hasDialogOpened: Boolean = false | |||
There was a problem hiding this comment.
hasPointReadDialogOpened 이런 식으로 무슨 다이얼로그인지 명시해주면 좋을 듯,,
요거 이 방법밖에 없겠죠? ㅜ 마땅한 게 안 떠오르넹
jihyunniiii
approved these changes
Sep 29, 2024
…course-detail-amplitude # Conflicts: # app/src/main/java/org/sopt/dateroad/presentation/ui/coursedetail/CourseDetailScreen.kt # app/src/main/java/org/sopt/dateroad/presentation/ui/coursedetail/CourseDetailViewModel.kt # app/src/main/java/org/sopt/dateroad/presentation/util/Constraints.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
view_course_details 이벤트
click_course_back 이벤트
click_course_likes 이벤트
Uncompleted Tasks 😅
To Reviewers 📢
유저 프로퍼티 빼고 다 컷! ㅋㅋ