Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for negative strides #73

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Fixes for negative strides #73

merged 5 commits into from
Jul 30, 2024

Conversation

Thoemi09
Copy link
Contributor

  • Fixes an issue with assigning a scalar to a 1D view with negative strides.
  • Redefines the functions is_contiguous and is_strided_1d in nda::idx_map to also apply to views with negative strides.
  • Introduces the function has_positive_strides in nda::idx_map.

@Thoemi09 Thoemi09 force-pushed the DEV_STRIDE_ISSUES branch from 37d784b to 9176771 Compare July 4, 2024 09:56
@Thoemi09 Thoemi09 force-pushed the DEV_STRIDE_ISSUES branch from 9176771 to 86b3390 Compare July 18, 2024 14:02
@Wentzell Wentzell force-pushed the unstable branch 8 times, most recently from 2cdbb07 to eac10ed Compare July 30, 2024 16:18
@Wentzell Wentzell force-pushed the DEV_STRIDE_ISSUES branch from 86b3390 to 5d10097 Compare July 30, 2024 22:01
Wentzell
Wentzell approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@Wentzell Wentzell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Thoemi09 for identifying and fixing these issues!

@Wentzell Wentzell merged commit 5d10097 into TRIQS:unstable Jul 30, 2024
4 of 5 checks passed
@Thoemi09 Thoemi09 deleted the DEV_STRIDE_ISSUES branch August 9, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wentzell Wentzell Wentzell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thoemi09 @Wentzell