Switch DirectInput+XInput+XAudio2/OpenAL to use Vortice/SilkNET instead of SlimDX/OpenTK3 #3622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a lot less painful than SharpAudio was, also just works!
Seems to work all correctly
CasualPokePlayer
changed the title
This makes SlimDX's Direct3D9 stuff the only usage of SlimDX, a future implementation with Veldrid (or anything else really) will be able to remove SlimDX entirely (Also of course, SlimDX is used for DirectSound, but that API is ancient/deprecated in favor of XAudio2 and doesn't need to be around when we move to modern .NET. Also of course since we've moved over to newer XAudio2 which is shipped with modern Windows anyways there's probably very little chance of users not having XAudio2)
CasualPokePlayer
changed the title
also add some debugging code to see what's going on maybe
|
Seems that Vortice is no longer supports standard 2.0 in its 3.x releases (it only supports net 6+), so we'll have to stay in 2.4.2 for the time being (not really an issue, outside of this slightly annoying hack which won't be needed in 3.x releases) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot less painful than SharpAudio was, also just works!
Also see: #2261
EDIT: Also now just replaces DirectInput+XInput alongside the XAudio2/OpenAL stuff.