Replace assembly references with NuGet packages where possible #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoshiRulz
force-pushed
the
noogettification
branch
2 times, most recently
from
013f974
to
d5f4608
Compare
YoshiRulz
force-pushed
the
noogettification
branch
from
d5f4608
to
2ac51e4
Compare
adelikat
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1415
Problems / future work:
ICSharpCode.SharpZipLibwas version1.0.6324.40785which isn't available on NuGet. This PR changes the targeted version to1.1.0.145as nothing was published between1.0.0(actually1.0.0.999) and that version.GongShelldoesn't seem to be on NuGet.SlimDXassembly is a modified copy of version4.0.13.43(and unhelpfully has that version in its metadata).PeNetassembly is a modified copy of... well it's labelled1.0.0.0, but it doesn't match any version1.0.0on NuGet, or any of0.1.0through0.4.6which also had an assembly version of1.0.0.0. I tried decompiling a sample of them looking for the "missing" propertyImportFunction.Thunkbut it doesn't seem to be in the published history at all.There should probably be an issue for updating our dependencies to the latest stable version.