Skip to content

task/WG-432 rework hooks, maps and feature tree to minimize renders #991

task/WG-432 rework hooks, maps and feature tree to minimize renders

task/WG-432 rework hooks, maps and feature tree to minimize renders #991

Triggered via pull request February 28, 2025 02:15
Status Failure
Total duration 1m 55s
Artifacts

main.yml

on: pull_request
Angular-Unit-Tests
52s
Angular-Unit-Tests
Angular-Linting
53s
Angular-Linting
React-Unit-Tests
1m 44s
React-Unit-Tests
React-Linting
39s
React-Linting
React-Build
56s
React-Build
Fit to window
Zoom out
Zoom in

Annotations

9 errors and 6 warnings
React-Linting: react/src/components/FeatureFileTree/FeatureFileTree.tsx#L245
'node.featureNode' is missing in props validation
React-Linting: react/src/components/FeatureFileTree/FeatureFileTree.tsx#L247
'node.featureNode.isDirectory' is missing in props validation
React-Linting: react/src/components/FeatureFileTree/FeatureFileTree.tsx#L247
'node.key' is missing in props validation
React-Linting: react/src/components/FeatureFileTree/FeatureFileTree.tsx#L248
'node.key' is missing in props validation
React-Linting: react/src/components/Map/Map.tsx#L1
'useEffect' is defined but never used
React-Linting: react/src/components/Map/Map.tsx#L1
'useRef' is defined but never used
React-Linting: react/src/test/testUtil.tsx#L77
Insert `·`
React-Linting
Process completed with exit code 1.
React-Unit-Tests
Process completed with exit code 1.
React-Linting: react/src/components/CreateMapModal/CreateMapModal.tsx#L91
React Hook useEffect has a missing dependency: 'trigger'. Either include it or remove the dependency array
React-Linting: react/src/components/Files/FileListing.tsx#L147
React Hook useEffect has missing dependencies: 'communityDataSystem?.id', 'myDataSystem?.id', 'onFolderSelect', 'onSystemSelect', 'publishedDataSystem?.id', 'systems', and 'user?.username'. Either include them or remove the dependency array. If 'onSystemSelect' changes too often, find the parent component that defines it and wrap that definition in useCallback
React-Linting: react/src/components/Map/Map.tsx#L71
React Hook useMemo has a missing dependency: 'baseLayers'. Either include it or remove the dependency array
React-Linting: react/src/components/Map/Map.tsx#L71
React Hook useMemo has a complex expression in the dependency array. Extract it to a separate variable so it can be statically checked
React-Linting: react/src/components/Systems/SystemSelect.tsx#L40
React Hook useEffect has a missing dependency: 'reset'. Either include it or remove the dependency array
React-Linting: react/src/pages/Login/Login.tsx#L29
React Hook useEffect has missing dependencies: 'configuration.geoapiUrl', 'isAuthenticated', 'location.search', and 'navigate'. Either include them or remove the dependency array