task/WG-432 rework hooks, maps and feature tree to minimize renders #339
Conversation
…hanges-filter-changes
…hanges-filter-changes
…hanges-filter-changes
…hanges-filter-changes
Moving functions out of the render cycle and into memoized component properties. Changes account for feature selection time from 700ms to 20ms
Prevent unnecessary re-renders by removing searchParams dependency as selectedFeatureId is enough. Also useMemo for selectedFeatureId determination
Ensure that setSelectedFeatureID is not dependent on selectedFeatureId
Make some optimizations in Map and FeatureFileTree
nathanfranklin
requested review from
rstijerina,
shayanaijaz and
sophia-massie
| const prevDataRef = useRef<FeatureCollection | undefined>(undefined); | ||
| const prevStateRef = useRef<{ pending: boolean; error: boolean }>({ | ||
| pending: false, | ||
| error: false, | ||
| }); |
There was a problem hiding this comment.
Just curious, I wonder if react query's keepPreviousData could be of use here?
There was a problem hiding this comment.
Good idea; that got me working on different approaches. I tried that way and some others but it got tricky with this due to all the different cases and uses, so I ended up keeping some state (with zustand) that could provide data/status for useCurrentFeatures. While maybe not the best (or final) solution, now all the use scenarios are fixed. I couldn't manage getting all the cases to work with react-query and my half-baked interpretation of checking all inactive/active queries.
There was a problem hiding this comment.
Sounds good. I've had good luck with ensureQueryData, prefetching, and suspense queries to ensure data is present regardless of status, but not sure if that's applicable here off the bat
Co-authored-by: Sal Tijerina <[email protected]>
…hanges-filter-changes
nathanfranklin
deleted the
task/WG-432-rework-state-regarding-feature-changes-filter-changes
branch
Overview:
This PR reworked hooks, maps and feature tree to minimize renders and optimize things.
The main issues we noticed were:
The fixes were:
useCurrentFeatureshook so that provides stable reference to the latest featuresuseFeatureSelectionhook to ensure that setSelectedFeatureID is not dependent on selectedFeatureIdOff-topic change:
PR Status:
Related Jira tickets:
Summary of Changes:
Testing Steps:
Notes:
TODO