Refactor script/style/template lang attribute contexts #7
+522
−318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 18, 2024 18:00
This commit... 1. copies most script/style embedding contexts from Svelte to add named contexts for each embedded script and style syntax. 2. scopes `lang="..."` attributes `meta.attribute-with-value.lang` to support lang value completions see also: sublimehq/Packages#4079 3. also accepts `language="..."` as synonym for `lang="..."`, as it has been seen in various other languages and has therefore also been added to default packages. 4. adds support for "babel" scripts 5. supports `"coffeescript"` as synonym for `"coffee"` as Svelte uses the former one - just to be aligned. 6. fixes scope for "Slim" templates
Resolves #3
deathaxe
force-pushed
the
pr/lang-decider
branch
from
db8ed0f to
205abe7
Compare
Closed
FichteFoll
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3
This PR...
introduces named contexts for each embedded script/style/template language.
Most of them have been copied from Svelte with some gaps filled.
adds support for JSX/TSX scripts
Note: For details, please refer to commit messages.