Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a ST4126+ version #9

Closed
deathaxe opened this issue Nov 18, 2024 · 2 comments · Fixed by #17
Closed

Create a ST4126+ version #9

deathaxe opened this issue Nov 18, 2024 · 2 comments · Fixed by #17
Labels

Comments

@deathaxe
Copy link
Member

In order to avoid adding duplicate style/script tag patterns and avoid possible conflicts with updated core HTML syntax a Vue syntax for ST4126+ with obsolete contexts removed should be created and released separately.

Various contexts are marked "required until 4113" as they have been added in ST4114. I'd suggest to use the next available stable build 4126 as waypoint to provide a backward-incompatible syntax.

requires: #7

@FichteFoll
Copy link
Member

Yes, I am perfectly fine with this decision. We just need to create a branch before introducing backwards-incompatible changes and imo targetting the next stable version is a fine choice. 4126 was over 3 years ago anyway.

I don't remember the various core syntax changes breakpoints by heart. Has anything else worthwhile been done to the default syntaxes since then that could warrant another breakpoint?

@deathaxe
Copy link
Member Author

A major change with effect on syntax tests is sublimehq/Packages#4020.

It's crucial for proper indentation of script/style content and also may be worth applying to template tags.

So if we keep all related variables and copy patterns from liked PR, we shouldn't need another breakpooint. All the other fixes should apply automatically for newer ST builds.

deathaxe pushed a commit that referenced this issue Nov 21, 2024
Resolves #9

Primary goal: Avoid duplicate `script` and `style` tag patterns in `tag-html` context.

It removes all contexts, which are present only for backward compatibility with ST4107..4113.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants