Don't call object.Equals() from '=='-operators but use Equals implementations on the type. #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution @danielcweber - this makes perfect sense! |
SteveDunn
reviewed
Aug 13, 2024
danielcweber
force-pushed
the
AvoidObjectEquals
branch
2 times, most recently
from
2b082e3
to
a14ccc5
Compare
|
Added snapshots. Still a WIP because this PR is based on #656. |
…ntations on the type.
danielcweber
force-pushed
the
AvoidObjectEquals
branch
from
a14ccc5
to
c72df71
Compare
danielcweber
changed the title
SteveDunn
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress just to show the issue/possible solution and start a discussion. No test, no snapshots yet.
Currently, the
==operators call the staticobject.Equalsmethod that operates onobjectparameters. This induces boxing (in case the value object is a struct) and can be avoided since the the value object already defines correctly typedEqualsmethods. Subsequently, this PR also changes the==operator implementation when comparison is done with an underlying type and establishes symmetry for the!=operators, ie.x != yshould just be!(x == y).