Skip to content

Commit

Permalink
Merge pull request #655 from danielcweber/AvoidObjectEquals
Browse files Browse the repository at this point in the history
Don't call object.Equals() from '=='-operators but use Equals implementations on the type.
  • Loading branch information
SteveDunn committed Aug 16, 2024
2 parents 35dc12a + c72df71 commit 3b3c04f
Show file tree
Hide file tree
Showing 6,353 changed files with 6,366 additions and 6,366 deletions.
The diff you're trying to view is too large. We only load the first 3000 changed files.
2 changes: 1 addition & 1 deletion src/Vogen/Generators/StructGenerator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ public readonly {itemUnderlyingType} Value
}}
{GenerateEqualsMethodsAndOperators.GenerateEqualsMethodsForAStruct(item, tds)}
public static global::System.Boolean operator ==({structName} left, {structName} right) => Equals(left, right);
public static global::System.Boolean operator ==({structName} left, {structName} right) => left.Equals(right);
public static global::System.Boolean operator !=({structName} left, {structName} right) => !(left == right);
{GenerateEqualsMethodsAndOperators.GenerateEqualsOperatorsForPrimitivesIfNeeded(itemUnderlyingType, structName, item)}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Age && Equals((Age)obj);
}

public static global::System.Boolean operator ==(Age left, Age right) => Equals(left, right);
public static global::System.Boolean operator ==(Age left, Age right) => left.Equals(right);
public static global::System.Boolean operator !=(Age left, Age right) => !(left == right);
public static global::System.Boolean operator ==(Age left, System.Int32 right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Age left, System.Int32 right) => !Equals(left.Value, right);
Expand Down Expand Up @@ -838,7 +838,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Name && Equals((Name)obj);
}

public static global::System.Boolean operator ==(Name left, Name right) => Equals(left, right);
public static global::System.Boolean operator ==(Name left, Name right) => left.Equals(right);
public static global::System.Boolean operator !=(Name left, Name right) => !(left == right);
public static global::System.Boolean operator ==(Name left, System.String right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Name left, System.String right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Vo && Equals((Vo)obj);
}

public static global::System.Boolean operator ==(Vo left, Vo right) => Equals(left, right);
public static global::System.Boolean operator ==(Vo left, Vo right) => left.Equals(right);
public static global::System.Boolean operator !=(Vo left, Vo right) => !(left == right);
public static global::System.Boolean operator ==(Vo left, System.Int32 right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Vo left, System.Int32 right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Vo && Equals((Vo)obj);
}

public static global::System.Boolean operator ==(Vo left, Vo right) => Equals(left, right);
public static global::System.Boolean operator ==(Vo left, Vo right) => left.Equals(right);
public static global::System.Boolean operator !=(Vo left, Vo right) => !(left == right);
public static global::System.Boolean operator ==(Vo left, System.Guid right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Vo left, System.Guid right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Vo && Equals((Vo)obj);
}

public static global::System.Boolean operator ==(Vo left, Vo right) => Equals(left, right);
public static global::System.Boolean operator ==(Vo left, Vo right) => left.Equals(right);
public static global::System.Boolean operator !=(Vo left, Vo right) => !(left == right);
public static global::System.Boolean operator ==(Vo left, System.Int32 right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Vo left, System.Int32 right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Vo && Equals((Vo)obj);
}

public static global::System.Boolean operator ==(Vo left, Vo right) => Equals(left, right);
public static global::System.Boolean operator ==(Vo left, Vo right) => left.Equals(right);
public static global::System.Boolean operator !=(Vo left, Vo right) => !(left == right);
public static global::System.Boolean operator ==(Vo left, System.Int32 right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Vo left, System.Int32 right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Vo && Equals((Vo)obj);
}

public static global::System.Boolean operator ==(Vo left, Vo right) => Equals(left, right);
public static global::System.Boolean operator ==(Vo left, Vo right) => left.Equals(right);
public static global::System.Boolean operator !=(Vo left, Vo right) => !(left == right);
public static global::System.Boolean operator ==(Vo left, System.Guid right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Vo left, System.Guid right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Vo && Equals((Vo)obj);
}

public static global::System.Boolean operator ==(Vo left, Vo right) => Equals(left, right);
public static global::System.Boolean operator ==(Vo left, Vo right) => left.Equals(right);
public static global::System.Boolean operator !=(Vo left, Vo right) => !(left == right);
public static global::System.Boolean operator ==(Vo left, System.Int32 right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Vo left, System.Int32 right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Vo && Equals((Vo)obj);
}

public static global::System.Boolean operator ==(Vo left, Vo right) => Equals(left, right);
public static global::System.Boolean operator ==(Vo left, Vo right) => left.Equals(right);
public static global::System.Boolean operator !=(Vo left, Vo right) => !(left == right);
public static global::System.Boolean operator ==(Vo left, System.Int32 right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Vo left, System.Int32 right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Vo && Equals((Vo)obj);
}

public static global::System.Boolean operator ==(Vo left, Vo right) => Equals(left, right);
public static global::System.Boolean operator ==(Vo left, Vo right) => left.Equals(right);
public static global::System.Boolean operator !=(Vo left, Vo right) => !(left == right);
public static global::System.Boolean operator ==(Vo left, System.Int32 right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Vo left, System.Int32 right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Vo && Equals((Vo)obj);
}

public static global::System.Boolean operator ==(Vo left, Vo right) => Equals(left, right);
public static global::System.Boolean operator ==(Vo left, Vo right) => left.Equals(right);
public static global::System.Boolean operator !=(Vo left, Vo right) => !(left == right);
public static global::System.Boolean operator ==(Vo left, System.Guid right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Vo left, System.Guid right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Vo && Equals((Vo)obj);
}

public static global::System.Boolean operator ==(Vo left, Vo right) => Equals(left, right);
public static global::System.Boolean operator ==(Vo left, Vo right) => left.Equals(right);
public static global::System.Boolean operator !=(Vo left, Vo right) => !(left == right);
public static global::System.Boolean operator ==(Vo left, System.Int32 right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Vo left, System.Int32 right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Vo && Equals((Vo)obj);
}

public static global::System.Boolean operator ==(Vo left, Vo right) => Equals(left, right);
public static global::System.Boolean operator ==(Vo left, Vo right) => left.Equals(right);
public static global::System.Boolean operator !=(Vo left, Vo right) => !(left == right);
public static global::System.Boolean operator ==(Vo left, System.Int32 right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Vo left, System.Int32 right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Vo && Equals((Vo)obj);
}

public static global::System.Boolean operator ==(Vo left, Vo right) => Equals(left, right);
public static global::System.Boolean operator ==(Vo left, Vo right) => left.Equals(right);
public static global::System.Boolean operator !=(Vo left, Vo right) => !(left == right);
public static global::System.Boolean operator ==(Vo left, System.Guid right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Vo left, System.Guid right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Vo && Equals((Vo)obj);
}

public static global::System.Boolean operator ==(Vo left, Vo right) => Equals(left, right);
public static global::System.Boolean operator ==(Vo left, Vo right) => left.Equals(right);
public static global::System.Boolean operator !=(Vo left, Vo right) => !(left == right);
public static global::System.Boolean operator ==(Vo left, System.Int32 right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Vo left, System.Int32 right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Vo && Equals((Vo)obj);
}

public static global::System.Boolean operator ==(Vo left, Vo right) => Equals(left, right);
public static global::System.Boolean operator ==(Vo left, Vo right) => left.Equals(right);
public static global::System.Boolean operator !=(Vo left, Vo right) => !(left == right);
public static global::System.Boolean operator ==(Vo left, System.Int32 right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Vo left, System.Int32 right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Vo && Equals((Vo)obj);
}

public static global::System.Boolean operator ==(Vo left, Vo right) => Equals(left, right);
public static global::System.Boolean operator ==(Vo left, Vo right) => left.Equals(right);
public static global::System.Boolean operator !=(Vo left, Vo right) => !(left == right);
public static global::System.Boolean operator ==(Vo left, System.Guid right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Vo left, System.Guid right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Vo && Equals((Vo)obj);
}

public static global::System.Boolean operator ==(Vo left, Vo right) => Equals(left, right);
public static global::System.Boolean operator ==(Vo left, Vo right) => left.Equals(right);
public static global::System.Boolean operator !=(Vo left, Vo right) => !(left == right);
public static global::System.Boolean operator ==(Vo left, System.Int32 right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Vo left, System.Int32 right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Vo && Equals((Vo)obj);
}

public static global::System.Boolean operator ==(Vo left, Vo right) => Equals(left, right);
public static global::System.Boolean operator ==(Vo left, Vo right) => left.Equals(right);
public static global::System.Boolean operator !=(Vo left, Vo right) => !(left == right);
public static global::System.Boolean operator ==(Vo left, System.Int32 right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Vo left, System.Int32 right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Vo && Equals((Vo)obj);
}

public static global::System.Boolean operator ==(Vo left, Vo right) => Equals(left, right);
public static global::System.Boolean operator ==(Vo left, Vo right) => left.Equals(right);
public static global::System.Boolean operator !=(Vo left, Vo right) => !(left == right);
public static global::System.Boolean operator ==(Vo left, System.Guid right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Vo left, System.Guid right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Vo && Equals((Vo)obj);
}

public static global::System.Boolean operator ==(Vo left, Vo right) => Equals(left, right);
public static global::System.Boolean operator ==(Vo left, Vo right) => left.Equals(right);
public static global::System.Boolean operator !=(Vo left, Vo right) => !(left == right);
public static global::System.Boolean operator ==(Vo left, System.Int32 right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Vo left, System.Int32 right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Vo && Equals((Vo)obj);
}

public static global::System.Boolean operator ==(Vo left, Vo right) => Equals(left, right);
public static global::System.Boolean operator ==(Vo left, Vo right) => left.Equals(right);
public static global::System.Boolean operator !=(Vo left, Vo right) => !(left == right);
public static global::System.Boolean operator ==(Vo left, System.Int32 right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Vo left, System.Int32 right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Vo && Equals((Vo)obj);
}

public static global::System.Boolean operator ==(Vo left, Vo right) => Equals(left, right);
public static global::System.Boolean operator ==(Vo left, Vo right) => left.Equals(right);
public static global::System.Boolean operator !=(Vo left, Vo right) => !(left == right);
public static global::System.Boolean operator ==(Vo left, System.Guid right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Vo left, System.Guid right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Vo && Equals((Vo)obj);
}

public static global::System.Boolean operator ==(Vo left, Vo right) => Equals(left, right);
public static global::System.Boolean operator ==(Vo left, Vo right) => left.Equals(right);
public static global::System.Boolean operator !=(Vo left, Vo right) => !(left == right);
public static global::System.Boolean operator ==(Vo left, System.Int32 right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Vo left, System.Int32 right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Vo && Equals((Vo)obj);
}

public static global::System.Boolean operator ==(Vo left, Vo right) => Equals(left, right);
public static global::System.Boolean operator ==(Vo left, Vo right) => left.Equals(right);
public static global::System.Boolean operator !=(Vo left, Vo right) => !(left == right);
public static global::System.Boolean operator ==(Vo left, System.Int32 right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Vo left, System.Int32 right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is HireDate && Equals((HireDate)obj);
}

public static global::System.Boolean operator ==(HireDate left, HireDate right) => Equals(left, right);
public static global::System.Boolean operator ==(HireDate left, HireDate right) => left.Equals(right);
public static global::System.Boolean operator !=(HireDate left, HireDate right) => !(left == right);
public static global::System.Boolean operator ==(HireDate left, System.DateTime right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(HireDate left, System.DateTime right) => !Equals(left.Value, right);
Expand Down Expand Up @@ -908,7 +908,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Name && Equals((Name)obj);
}

public static global::System.Boolean operator ==(Name left, Name right) => Equals(left, right);
public static global::System.Boolean operator ==(Name left, Name right) => left.Equals(right);
public static global::System.Boolean operator !=(Name left, Name right) => !(left == right);
public static global::System.Boolean operator ==(Name left, System.String right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Name left, System.String right) => !Equals(left.Value, right);
Expand Down Expand Up @@ -1206,7 +1206,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Age && Equals((Age)obj);
}

public static global::System.Boolean operator ==(Age left, Age right) => Equals(left, right);
public static global::System.Boolean operator ==(Age left, Age right) => left.Equals(right);
public static global::System.Boolean operator !=(Age left, Age right) => !(left == right);
public static global::System.Boolean operator ==(Age left, System.Int32 right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Age left, System.Int32 right) => !Equals(left.Value, right);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ private readonly global::System.Diagnostics.StackTrace _stackTrace = null;
return obj is Vo && Equals((Vo)obj);
}

public static global::System.Boolean operator ==(Vo left, Vo right) => Equals(left, right);
public static global::System.Boolean operator ==(Vo left, Vo right) => left.Equals(right);
public static global::System.Boolean operator !=(Vo left, Vo right) => !(left == right);
public static global::System.Boolean operator ==(Vo left, System.Int32 right) => Equals(left.Value, right);
public static global::System.Boolean operator !=(Vo left, System.Int32 right) => !Equals(left.Value, right);
Expand Down
Loading

0 comments on commit 3b3c04f

Please sign in to comment.