Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix tablet writer add chunk when larger than 2GB (backport #51152) #51196

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 20, 2024

Why I'm doing:

There two issues now when handle >2GB chunk:

  1. starrocks.PTabletWriterAddChunksRequest exceeded maximum protobuf size of 2GB: 4194416177
void serialize_to_iobuf(const T& proto_obj, butil::IOBuf* iobuf) {
    butil::IOBuf tmp_iobuf;
    butil::IOBufAsZeroCopyOutputStream wrapper(&tmp_iobuf);
    proto_obj.SerializeToZeroCopyStream(&wrapper);

SerializeToZeroCopyStream will fail when handle >2GB chunk.

  1. In previous pr [BugFix] Fix brpc continuously fail after backend host restart #40229, It introduced a bug about missing set http protocol for BRPC client.
 input_messenger.cpp:96] A message from 172.26.94.64:39672(protocol=baidu_std) is bigger than 2147483648 bytes, the connection will be closed. Set max_body_size to allow bigger messages

What I'm doing:

Fix these two issues:

  1. Seperate chunk from protobuf, so SerializeToZeroCopyStream won't fail because of >2GB serialize.
  2. Set http protocol for brpc::ChannelOptions when handle >2GB RPC.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #51152 done by [Mergify](https://mergify.com). ## Why I'm doing: There two issues now when handle >2GB chunk:
  1. starrocks.PTabletWriterAddChunksRequest exceeded maximum protobuf size of 2GB: 4194416177
void serialize_to_iobuf(const T& proto_obj, butil::IOBuf* iobuf) {
    butil::IOBuf tmp_iobuf;
    butil::IOBufAsZeroCopyOutputStream wrapper(&tmp_iobuf);
    proto_obj.SerializeToZeroCopyStream(&wrapper);

SerializeToZeroCopyStream will fail when handle >2GB chunk.

  1. In previous pr [BugFix] Fix brpc continuously fail after backend host restart #40229, It introduced a bug about missing set http protocol for BRPC client.
 input_messenger.cpp:96] A message from 172.26.94.64:39672(protocol=baidu_std) is bigger than 2147483648 bytes, the connection will be closed. Set max_body_size to allow bigger messages

What I'm doing:

Fix these two issues:

  1. Seperate chunk from protobuf, so SerializeToZeroCopyStream won't fail because of >2GB serialize.
  2. Set http protocol for brpc::ChannelOptions when handle >2GB RPC.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 1766f02)

# Conflicts:
#	be/src/util/brpc_stub_cache.h
#	be/src/util/internal_service_recoverable_stub.cpp
#	be/src/util/internal_service_recoverable_stub.h
Copy link
Contributor Author

mergify bot commented Sep 20, 2024

Cherry-pick of 1766f02 has failed:

On branch mergify/bp/branch-3.2/pr-51152
Your branch is up to date with 'origin/branch-3.2'.

You are currently cherry-picking commit 1766f02e1d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/exec/tablet_sink_index_channel.cpp
	modified:   be/src/exec/tablet_sink_index_channel.h
	modified:   be/src/service/service_be/internal_service.cpp

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   be/src/util/brpc_stub_cache.h
	deleted by us:   be/src/util/internal_service_recoverable_stub.cpp
	deleted by us:   be/src/util/internal_service_recoverable_stub.h

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Sep 20, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@luohaha luohaha reopened this Sep 20, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) September 20, 2024 06:12
Signed-off-by: Yixin Luo <[email protected]>
@wanpengfei-git wanpengfei-git merged commit 9e92a77 into branch-3.2 Sep 20, 2024
28 of 29 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-51152 branch September 20, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants