-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] fix tablet writer add chunk when larger than 2GB #51152
Merged
+89
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: luohaha <[email protected]>
Signed-off-by: luohaha <[email protected]>
Signed-off-by: luohaha <[email protected]>
Signed-off-by: luohaha <[email protected]>
Signed-off-by: luohaha <[email protected]>
Signed-off-by: luohaha <[email protected]>
chaoyli
previously approved these changes
Sep 19, 2024
wyb
reviewed
Sep 20, 2024
Signed-off-by: luohaha <[email protected]>
wyb
approved these changes
Sep 20, 2024
chaoyli
approved these changes
Sep 20, 2024
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]❌ fail : 41 / 59 (69.49%) file detail
|
dirtysalt
approved these changes
Sep 20, 2024
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
Signed-off-by: luohaha <[email protected]> (cherry picked from commit 1766f02) # Conflicts: # be/src/util/brpc_stub_cache.h # be/src/util/internal_service_recoverable_stub.cpp # be/src/util/internal_service_recoverable_stub.h
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
Signed-off-by: luohaha <[email protected]> (cherry picked from commit 1766f02) # Conflicts: # be/src/util/brpc_stub_cache.h # be/src/util/internal_service_recoverable_stub.cpp # be/src/util/internal_service_recoverable_stub.h
This was referenced Sep 20, 2024
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 20, 2024
…51152) (#51195) Signed-off-by: Yixin Luo <[email protected]> Co-authored-by: Yixin Luo <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 20, 2024
…51152) (#51196) Signed-off-by: Yixin Luo <[email protected]> Co-authored-by: Yixin Luo <[email protected]>
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
…51152) Signed-off-by: luohaha <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
There two issues now when handle >2GB chunk:
starrocks.PTabletWriterAddChunksRequest exceeded maximum protobuf size of 2GB: 4194416177
SerializeToZeroCopyStream
will fail when handle >2GB chunk.http
protocol for BRPC client.What I'm doing:
Fix these two issues:
SerializeToZeroCopyStream
won't fail because of >2GB serialize.brpc::ChannelOptions
when handle >2GB RPC.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: