Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Use data cache for pos-delete file #51123

Closed

Conversation

stephen-shelby
Copy link
Contributor

@stephen-shelby stephen-shelby commented Sep 18, 2024

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@stephen-shelby stephen-shelby requested review from a team as code owners September 18, 2024 13:06
@stephen-shelby stephen-shelby changed the title Use data cache for pos-delete file [Enhancement] Use data cache for pos-delete file Sep 18, 2024
@wanpengfei-git wanpengfei-git requested a review from a team September 18, 2024 13:06

return k_delete_file_path_slot;
}

SlotDescriptor& IcebergDeleteFileMeta::get_delete_file_pos_slot() {
static SlotDescriptor k_delete_file_pos_slot = IcebergDeleteFileMeta::gen_slot_helper(k_delete_file_pos);
static SlotDescriptor k_delete_file_pos_slot = gen_slot_helper(k_delete_file_pos);

return k_delete_file_pos_slot;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I improve my focus and productivity while studying?

Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

fail : 80 / 133 (60.15%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/exec/iceberg/iceberg_delete_builder.h 0 5 00.00% [28, 37, 38, 39, 51]
🔵 src/exec/hdfs_scanner_parquet.cpp 2 6 33.33% [30, 31, 32, 33]
🔵 src/exec/iceberg/iceberg_delete_builder.cpp 30 59 50.85% [58, 61, 63, 66, 67, 69, 70, 78, 79, 80, 82, 85, 88, 90, 96, 97, 100, 101, 102, 103, 104, 105, 106, 109, 110, 112, 114, 115, 118]
🔵 src/connector/hive_connector.cpp 20 35 57.14% [296, 297, 298, 299, 300, 301, 302, 349, 351, 352, 607, 608, 609, 611, 612]
🔵 src/exec/hdfs_scanner.cpp 13 13 100.00% []
🔵 src/formats/parquet/file_reader.cpp 7 7 100.00% []
🔵 src/exec/hdfs_scanner_orc.cpp 8 8 100.00% []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants