[BugFix] Fix REPLACE constant fold (backport #50828) #50846
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
The behaviour of the Java native method
String::replace(target, replacement)
is different from that of BE.It considers the empty target string
""
as a valid character sequence and inserts thereplacement
string to each gap between chars.What I'm doing:
Use
org.apache.commons.lang.String::replace
instead of Java native version.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #50828 done by [Mergify](https://mergify.com). ## Why I'm doing: The behaviour of the Java native method `String::replace(target, replacement)` is different from that of BE.
It considers the empty target string
""
as a valid character sequence and inserts thereplacement
string to each gap between chars.What I'm doing:
Use
org.apache.commons.lang.String::replace
instead of Java native version.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: