Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix REPLACE constant fold (backport #50828) #50846

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 9, 2024

Why I'm doing:

The behaviour of the Java native method String::replace(target, replacement) is different from that of BE.

It considers the empty target string "" as a valid character sequence and inserts the replacement string to each gap between chars.

select REPLACE( "foo bar bar" ,  "" ,  "123" );
+-------------------------------------------------+
| replace('foo bar bar', '', '123')               |
+-------------------------------------------------+
| 123f123o123o123 123b123a123r123 123b123a123r123 |
+-------------------------------------------------+

explain select REPLACE( "foo bar bar" ,  "" ,  "123" );
+-------------------------------------------------------------------+
| Explain String                                                    |
+-------------------------------------------------------------------+
| PLAN FRAGMENT 0                                                   |
|  OUTPUT EXPRS:2: replace                                          |
|   PARTITION: UNPARTITIONED                                        |
|                                                                   |
|   RESULT SINK                                                     |
|                                                                   |
|   1:Project                                                       |
|   |  <slot 2> : '123f123o123o123 123b123a123r123 123b123a123r123' |
|   |                                                               |
|   0:UNION                                                         |
|      constant exprs:                                              |
|          NULL                                                     |
+-------------------------------------------------------------------+

What I'm doing:

Use org.apache.commons.lang.String::replace instead of Java native version.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #50828 done by [Mergify](https://mergify.com). ## Why I'm doing: The behaviour of the Java native method `String::replace(target, replacement)` is different from that of BE.

It considers the empty target string "" as a valid character sequence and inserts the replacement string to each gap between chars.

select REPLACE( "foo bar bar" ,  "" ,  "123" );
+-------------------------------------------------+
| replace('foo bar bar', '', '123')               |
+-------------------------------------------------+
| 123f123o123o123 123b123a123r123 123b123a123r123 |
+-------------------------------------------------+

explain select REPLACE( "foo bar bar" ,  "" ,  "123" );
+-------------------------------------------------------------------+
| Explain String                                                    |
+-------------------------------------------------------------------+
| PLAN FRAGMENT 0                                                   |
|  OUTPUT EXPRS:2: replace                                          |
|   PARTITION: UNPARTITIONED                                        |
|                                                                   |
|   RESULT SINK                                                     |
|                                                                   |
|   1:Project                                                       |
|   |  <slot 2> : '123f123o123o123 123b123a123r123 123b123a123r123' |
|   |                                                               |
|   0:UNION                                                         |
|      constant exprs:                                              |
|          NULL                                                     |
+-------------------------------------------------------------------+

What I'm doing:

Use org.apache.commons.lang.String::replace instead of Java native version.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: zihe.liu <[email protected]>
(cherry picked from commit fe04681)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/ConstantExpressionTest.java
@mergify mergify bot added the conflicts label Sep 9, 2024
Copy link
Contributor Author

mergify bot commented Sep 9, 2024

Cherry-pick of fe04681 has failed:

On branch mergify/bp/branch-3.2/pr-50828
Your branch is up to date with 'origin/branch-3.2'.

You are currently cherry-picking commit fe04681389.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctions.java
	modified:   fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctionsTest.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/test/java/com/starrocks/sql/plan/ConstantExpressionTest.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Sep 9, 2024
24 tasks
@mergify mergify bot closed this Sep 9, 2024
Copy link
Contributor Author

mergify bot commented Sep 9, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-3.2/pr-50828 branch September 9, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant