-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Fix REPLACE constant fold #50828
Merged
ZiheLiu
merged 3 commits into
StarRocks:main
from
ZiheLiu:fix/main/replace_constant_fold
Sep 9, 2024
Merged
[BugFix] Fix REPLACE constant fold #50828
ZiheLiu
merged 3 commits into
StarRocks:main
from
ZiheLiu:fix/main/replace_constant_fold
Sep 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zihe.liu <[email protected]>
Signed-off-by: zihe.liu <[email protected]>
Signed-off-by: zihe.liu <[email protected]>
packy92
approved these changes
Sep 9, 2024
Quality Gate passedIssues Measures |
silverbullet233
approved these changes
Sep 9, 2024
kangkaisen
approved these changes
Sep 9, 2024
Seaven
approved these changes
Sep 9, 2024
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 2 / 2 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
Signed-off-by: zihe.liu <[email protected]> (cherry picked from commit fe04681)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
Signed-off-by: zihe.liu <[email protected]> (cherry picked from commit fe04681) # Conflicts: # fe/fe-core/src/test/java/com/starrocks/sql/plan/ConstantExpressionTest.java
42 tasks
ZiheLiu
added a commit
to ZiheLiu/starrocks
that referenced
this pull request
Sep 9, 2024
Signed-off-by: zihe.liu <[email protected]>
24 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 9, 2024
Co-authored-by: zihe.liu <[email protected]>
packy92
pushed a commit
that referenced
this pull request
Sep 9, 2024
Signed-off-by: zihe.liu <[email protected]>
HangyuanLiu
pushed a commit
to HangyuanLiu/starrocks
that referenced
this pull request
Sep 12, 2024
Signed-off-by: zihe.liu <[email protected]>
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
Signed-off-by: zihe.liu <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
The behaviour of the Java native method
String::replace(target, replacement)
is different from that of BE.It considers the empty target string
""
as a valid character sequence and inserts thereplacement
string to each gap between chars.What I'm doing:
Use
org.apache.commons.lang.String::replace
instead of Java native version.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: