Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix REPLACE constant fold #50828

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

ZiheLiu
Copy link
Contributor

@ZiheLiu ZiheLiu commented Sep 9, 2024

Why I'm doing:

The behaviour of the Java native method String::replace(target, replacement) is different from that of BE.

It considers the empty target string "" as a valid character sequence and inserts the replacement string to each gap between chars.

select REPLACE( "foo bar bar" ,  "" ,  "123" );
+-------------------------------------------------+
| replace('foo bar bar', '', '123')               |
+-------------------------------------------------+
| 123f123o123o123 123b123a123r123 123b123a123r123 |
+-------------------------------------------------+

explain select REPLACE( "foo bar bar" ,  "" ,  "123" );
+-------------------------------------------------------------------+
| Explain String                                                    |
+-------------------------------------------------------------------+
| PLAN FRAGMENT 0                                                   |
|  OUTPUT EXPRS:2: replace                                          |
|   PARTITION: UNPARTITIONED                                        |
|                                                                   |
|   RESULT SINK                                                     |
|                                                                   |
|   1:Project                                                       |
|   |  <slot 2> : '123f123o123o123 123b123a123r123 123b123a123r123' |
|   |                                                               |
|   0:UNION                                                         |
|      constant exprs:                                              |
|          NULL                                                     |
+-------------------------------------------------------------------+

What I'm doing:

Use org.apache.commons.lang.String::replace instead of Java native version.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@ZiheLiu ZiheLiu requested a review from a team as a code owner September 9, 2024 03:11
@mergify mergify bot assigned ZiheLiu Sep 9, 2024
Signed-off-by: zihe.liu <[email protected]>
Signed-off-by: zihe.liu <[email protected]>
Copy link

sonarcloud bot commented Sep 9, 2024

Copy link

github-actions bot commented Sep 9, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Sep 9, 2024

[FE Incremental Coverage Report]

pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctions.java 2 2 100.00% []

Copy link

github-actions bot commented Sep 9, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@ZiheLiu ZiheLiu merged commit fe04681 into StarRocks:main Sep 9, 2024
73 checks passed
@ZiheLiu ZiheLiu deleted the fix/main/replace_constant_fold branch September 9, 2024 08:12
Copy link

github-actions bot commented Sep 9, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Sep 9, 2024
Copy link
Contributor

mergify bot commented Sep 9, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 9, 2024

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 9, 2024
Signed-off-by: zihe.liu <[email protected]>
(cherry picked from commit fe04681)
mergify bot pushed a commit that referenced this pull request Sep 9, 2024
Signed-off-by: zihe.liu <[email protected]>
(cherry picked from commit fe04681)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/ConstantExpressionTest.java
ZiheLiu added a commit to ZiheLiu/starrocks that referenced this pull request Sep 9, 2024
wanpengfei-git pushed a commit that referenced this pull request Sep 9, 2024
packy92 pushed a commit that referenced this pull request Sep 9, 2024
HangyuanLiu pushed a commit to HangyuanLiu/starrocks that referenced this pull request Sep 12, 2024
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants