Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] MV rewrite may generate wrong plans if query only contains constant call operators (backport #50757) #50777

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 6, 2024

Why I'm doing:

CREATE MATERIALIZED VIEW `test_mv1` (`1`, `count(DISTINCT k2)`)
DISTRIBUTED BY RANDOM
REFRESH MANUAL
PROPERTIES (
"replicated_storage" = "true",
"replication_num" = "1",
"storage_medium" = "HDD"
)
AS SELECT 1 AS `1`, count(DISTINCT `s1`.`k2`) AS `count(DISTINCT k2)`
FROM `test`.`s1`;

mysql> explain select count(1) from s1;
+-----------------------------+
| Explain String              |
+-----------------------------+
| PLAN FRAGMENT 0             |
|  OUTPUT EXPRS:4: count      |
|   PARTITION: UNPARTITIONED  |
|                             |
|   RESULT SINK               |
|                             |
|   2:EXCHANGE                |
|                             |
| PLAN FRAGMENT 1             |
|  OUTPUT EXPRS:              |
|   PARTITION: RANDOM         |
|                             |
|   STREAM DATA SINK          |
|     EXCHANGE ID: 02         |
|     UNPARTITIONED           |
|                             |
|   1:Project                 |
|   |  <slot 4> : count(5: 1) |
|   |                         |
|   0:OlapScanNode            |
|      TABLE: test_mv1        |
|      PREAGGREGATION: ON     |
|      partitions=1/1         |
|      rollup: test_mv1       |
|      tabletRatio=2/2        |
|      tabletList=30937,30939 |
|      cardinality=1          |
|      avgRowSize=8.0         |
|      MaterializedView: true |
+-----------------------------+
29 rows in set (0.00 sec)

Query will face this error:

mysql> select count(1) from s1; 

ERROR 1064 (HY000): Vectorized engine does not support the operator, node_type: 0 backend [id=10001] [host=172.26.92.227]

What I'm doing:

  • Fix mv rewrite wrong plans if query only contains constant call operators

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #50757 done by [Mergify](https://mergify.com). ## Why I'm doing: ``` CREATE MATERIALIZED VIEW `test_mv1` (`1`, `count(DISTINCT k2)`) DISTRIBUTED BY RANDOM REFRESH MANUAL PROPERTIES ( "replicated_storage" = "true", "replication_num" = "1", "storage_medium" = "HDD" ) AS SELECT 1 AS `1`, count(DISTINCT `s1`.`k2`) AS `count(DISTINCT k2)` FROM `test`.`s1`;

mysql> explain select count(1) from s1;
+-----------------------------+
| Explain String |
+-----------------------------+
| PLAN FRAGMENT 0 |
| OUTPUT EXPRS:4: count |
| PARTITION: UNPARTITIONED |
| |
| RESULT SINK |
| |
| 2:EXCHANGE |
| |
| PLAN FRAGMENT 1 |
| OUTPUT EXPRS: |
| PARTITION: RANDOM |
| |
| STREAM DATA SINK |
| EXCHANGE ID: 02 |
| UNPARTITIONED |
| |
| 1:Project |
| | <slot 4> : count(5: 1) |
| | |
| 0:OlapScanNode |
| TABLE: test_mv1 |
| PREAGGREGATION: ON |
| partitions=1/1 |
| rollup: test_mv1 |
| tabletRatio=2/2 |
| tabletList=30937,30939 |
| cardinality=1 |
| avgRowSize=8.0 |
| MaterializedView: true |
+-----------------------------+
29 rows in set (0.00 sec)


Query will face this error:

mysql> select count(1) from s1;

ERROR 1064 (HY000): Vectorized engine does not support the operator, node_type: 0 backend [id=10001] [host=172.26.92.227]


## What I'm doing:
- Fix mv rewrite wrong plans if query only contains constant call operators 

Fixes #issue

## What type of PR is this:

- [x] BugFix
- [ ] Feature
- [ ] Enhancement
- [ ] Refactor
- [ ] UT
- [ ] Doc
- [ ] Tool

Does this PR entail a change in behavior?

- [ ] Yes, this PR will result in a change in behavior.
- [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

- [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
- [ ] Parameter changes: default values, similar parameters but with different default values
- [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
- [ ] Feature removed
- [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

## Checklist:

- [x] I have added test cases for my bug fix or my new feature
- [ ] This pr needs user documentation (for new or modified features or behaviors)
  - [ ] I have added documentation for my new feature or new function
- [x] This is a backport pr


…onstant call operators (#50757)

Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit 215c164)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/planner/MaterializedViewManualTest.java
@mergify mergify bot added the conflicts label Sep 6, 2024
Copy link
Contributor Author

mergify bot commented Sep 6, 2024

Cherry-pick of 215c164 has failed:

On branch mergify/bp/branch-3.1/pr-50757
Your branch is up to date with 'origin/branch-3.1'.

You are currently cherry-picking commit 215c16499f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/EquationRewriter.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/test/java/com/starrocks/planner/MaterializedViewManualTest.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Sep 6, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

auto-merge was automatically disabled September 6, 2024 02:11

Pull request was closed

@mergify mergify bot deleted the mergify/bp/branch-3.1/pr-50757 branch September 6, 2024 02:12
@LiShuMing LiShuMing restored the mergify/bp/branch-3.1/pr-50757 branch September 9, 2024 02:06
@LiShuMing LiShuMing reopened this Sep 9, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) September 9, 2024 02:07
Signed-off-by: shuming.li <[email protected]>
Copy link

sonarcloud bot commented Sep 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@wanpengfei-git wanpengfei-git merged commit dd82d0f into branch-3.1 Sep 9, 2024
28 of 29 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.1/pr-50757 branch September 9, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants