Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] MV rewrite may generate wrong plans if query only contains constant call operators #50757

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Sep 5, 2024

Why I'm doing:

CREATE MATERIALIZED VIEW `test_mv1` (`1`, `count(DISTINCT k2)`)
DISTRIBUTED BY RANDOM
REFRESH MANUAL
PROPERTIES (
"replicated_storage" = "true",
"replication_num" = "1",
"storage_medium" = "HDD"
)
AS SELECT 1 AS `1`, count(DISTINCT `s1`.`k2`) AS `count(DISTINCT k2)`
FROM `test`.`s1`;

mysql> explain select count(1) from s1;
+-----------------------------+
| Explain String              |
+-----------------------------+
| PLAN FRAGMENT 0             |
|  OUTPUT EXPRS:4: count      |
|   PARTITION: UNPARTITIONED  |
|                             |
|   RESULT SINK               |
|                             |
|   2:EXCHANGE                |
|                             |
| PLAN FRAGMENT 1             |
|  OUTPUT EXPRS:              |
|   PARTITION: RANDOM         |
|                             |
|   STREAM DATA SINK          |
|     EXCHANGE ID: 02         |
|     UNPARTITIONED           |
|                             |
|   1:Project                 |
|   |  <slot 4> : count(5: 1) |
|   |                         |
|   0:OlapScanNode            |
|      TABLE: test_mv1        |
|      PREAGGREGATION: ON     |
|      partitions=1/1         |
|      rollup: test_mv1       |
|      tabletRatio=2/2        |
|      tabletList=30937,30939 |
|      cardinality=1          |
|      avgRowSize=8.0         |
|      MaterializedView: true |
+-----------------------------+
29 rows in set (0.00 sec)

Query will face this error:

mysql> select count(1) from s1; 

ERROR 1064 (HY000): Vectorized engine does not support the operator, node_type: 0 backend [id=10001] [host=172.26.92.227]

What I'm doing:

  • Fix mv rewrite wrong plans if query only contains constant call operators

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Copy link

sonarcloud bot commented Sep 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

github-actions bot commented Sep 5, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Sep 5, 2024

[FE Incremental Coverage Report]

pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/EquationRewriter.java 2 2 100.00% []

Copy link

github-actions bot commented Sep 5, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@LiShuMing LiShuMing enabled auto-merge (squash) September 6, 2024 02:07
@LiShuMing LiShuMing merged commit 215c164 into StarRocks:main Sep 6, 2024
76 of 80 checks passed
@LiShuMing LiShuMing deleted the fix/main/fix_mv_rewrite branch September 6, 2024 02:09
Copy link

github-actions bot commented Sep 6, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Sep 6, 2024
Copy link
Contributor

mergify bot commented Sep 6, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 6, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 6, 2024

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 6, 2024
…onstant call operators (#50757)

Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit 215c164)
mergify bot pushed a commit that referenced this pull request Sep 6, 2024
…onstant call operators (#50757)

Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit 215c164)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/planner/MaterializedViewManualTest.java
mergify bot pushed a commit that referenced this pull request Sep 6, 2024
…onstant call operators (#50757)

Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit 215c164)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/planner/MaterializedViewManualTest.java
wanpengfei-git pushed a commit that referenced this pull request Sep 6, 2024
…onstant call operators (backport #50757) (#50775)

Co-authored-by: shuming.li <[email protected]>
xiangguangyxg pushed a commit to xiangguangyxg/starrocks that referenced this pull request Sep 6, 2024
wanpengfei-git pushed a commit that referenced this pull request Sep 9, 2024
…onstant call operators (backport #50757) (#50777)

Signed-off-by: shuming.li <[email protected]>
Co-authored-by: shuming.li <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Sep 9, 2024
…onstant call operators (backport #50757) (#50776)

Signed-off-by: shuming.li <[email protected]>
Co-authored-by: shuming.li <[email protected]>
HangyuanLiu pushed a commit to HangyuanLiu/starrocks that referenced this pull request Sep 12, 2024
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
…onstant call operators (StarRocks#50757)

Signed-off-by: shuming.li <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants