Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] remove partition predicate from cardinality estimation (backport #50631) #50688

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 4, 2024

Why I'm doing:

What I'm doing:

Partition predicate has been applied to partition prune, which already contributed to the cardinality of scan node, so it should not be considered as predicate to estimate cardinality again, otherwise the estimation will be incorrect.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #50631 done by [Mergify](https://mergify.com). ## Why I'm doing:

What I'm doing:

Partition predicate has been applied to partition prune, which already contributed to the cardinality of scan node, so it should not be considered as predicate to estimate cardinality again, otherwise the estimation will be incorrect.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Copy link
Contributor Author

mergify bot commented Sep 4, 2024

Cherry-pick of a2db4b6 has failed:

On branch mergify/bp/branch-3.3/pr-50631
Your branch is up to date with 'origin/branch-3.3'.

You are currently cherry-picking commit a2db4b65a4.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/ListPartitionPruner.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/StatisticsCalculator.java
	modified:   fe/fe-core/src/test/java/com/starrocks/sql/plan/PartitionPruneTest.java

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   test/sql/test_list_partition/R/test_list_partition_cardinality
	deleted by us:   test/sql/test_list_partition/T/test_list_partition_cardinality

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Sep 4, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot closed this Sep 4, 2024
@mergify mergify bot deleted the mergify/bp/branch-3.3/pr-50631 branch September 4, 2024 11:16
@murphyatwork murphyatwork restored the mergify/bp/branch-3.3/pr-50631 branch September 4, 2024 11:37
@murphyatwork murphyatwork reopened this Sep 4, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) September 4, 2024 11:38
murphyatwork
murphyatwork previously approved these changes Sep 5, 2024
Copy link

sonarcloud bot commented Sep 5, 2024

@murphyatwork murphyatwork merged commit 6db0586 into branch-3.3 Sep 6, 2024
37 checks passed
@murphyatwork murphyatwork deleted the mergify/bp/branch-3.3/pr-50631 branch September 6, 2024 09:26
xiangguangyxg pushed a commit to xiangguangyxg/starrocks that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant