[Enhancement] remove partition predicate from cardinality estimation #50631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
...-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/ListPartitionPruner.java
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/StatisticsCalculator.java
Show resolved
Hide resolved
Signed-off-by: Murphy <[email protected]>
Signed-off-by: Murphy <[email protected]>
Signed-off-by: Murphy <[email protected]>
Signed-off-by: Murphy <[email protected]>
murphyatwork
force-pushed
the
murphy_fix_partition_predicate_statistics
branch
from
253a459
to
98f552c
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 53 / 53 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Seaven
approved these changes
Sep 4, 2024
LiShuMing
approved these changes
Sep 4, 2024
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
…50631) Signed-off-by: Murphy <[email protected]> (cherry picked from commit a2db4b6) # Conflicts: # test/sql/test_list_partition/R/test_list_partition_cardinality # test/sql/test_list_partition/T/test_list_partition_cardinality
Merged
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
…50631) Signed-off-by: Murphy <[email protected]> (cherry picked from commit a2db4b6) # Conflicts: # fe/fe-core/src/test/java/com/starrocks/sql/plan/PartitionPruneTest.java
Merged
42 tasks
murphyatwork
added a commit
that referenced
this pull request
Sep 4, 2024
…50631) Signed-off-by: Murphy <[email protected]> (cherry picked from commit a2db4b6) Signed-off-by: Murphy <[email protected]> # Conflicts: # fe/fe-core/src/test/java/com/starrocks/sql/plan/PartitionPruneTest.java
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 4, 2024
…(backport #50631) (#50689) Co-authored-by: Murphy <[email protected]>
murphyatwork
added a commit
that referenced
this pull request
Sep 5, 2024
…50631) Signed-off-by: Murphy <[email protected]> (cherry picked from commit a2db4b6)
murphyatwork
added a commit
that referenced
this pull request
Sep 6, 2024
…(backport #50631) (#50688) Co-authored-by: Murphy <[email protected]>
xiangguangyxg
pushed a commit
to xiangguangyxg/starrocks
that referenced
this pull request
Sep 6, 2024
…(backport StarRocks#50631) (StarRocks#50688) Co-authored-by: Murphy <[email protected]>
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
…tarRocks#50631) Signed-off-by: Murphy <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Partition predicate has been applied to partition prune, which already contributed to the cardinality of scan node, so it should not be considered as predicate to estimate cardinality again, otherwise the estimation will be incorrect.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: