Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support infer struct type from parquet in files() (backport #50481) #50571

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 2, 2024

Why I'm doing:

mysql> select * from  files("path" = "hive_struct_timestamp0.parquet", "format" = "parquet";
ERROR 1064 (HY000): arrow type 18 is not supported

struct type are infered to varchar or json type.

What I'm doing:

support struct type

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #50481 done by [Mergify](https://mergify.com). ## Why I'm doing: ``` mysql> select * from files("path" = "hive_struct_timestamp0.parquet", "format" = "parquet"; ERROR 1064 (HY000): arrow type 18 is not supported ```

What I'm doing:

support struct type

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: wyb <[email protected]>
(cherry picked from commit 37b6339)

# Conflicts:
#	test/sql/test_across_engine/R/test_sink_nested
Copy link
Contributor Author

mergify bot commented Sep 2, 2024

Cherry-pick of 37b6339 has failed:

On branch mergify/bp/branch-3.3/pr-50481
Your branch is up to date with 'origin/branch-3.3'.

You are currently cherry-picking commit 37b633948a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/exec/parquet_schema_builder.cpp
	modified:   be/test/exec/parquet_scanner_test.cpp
	modified:   test/sql/test_pipe/R/basic

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   test/sql/test_across_engine/R/test_sink_nested

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

wyb
wyb previously approved these changes Sep 2, 2024
Copy link
Contributor Author

mergify bot commented Sep 2, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot closed this Sep 2, 2024
@mergify mergify bot deleted the mergify/bp/branch-3.3/pr-50481 branch September 2, 2024 11:51
@wyb wyb restored the mergify/bp/branch-3.3/pr-50481 branch September 2, 2024 11:51
@wyb wyb reopened this Sep 2, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) September 2, 2024 11:51
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) September 2, 2024 12:20
@wanpengfei-git wanpengfei-git merged commit fb9009b into branch-3.3 Sep 2, 2024
40 of 44 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-50481 branch September 2, 2024 12:20
xiangguangyxg pushed a commit to xiangguangyxg/starrocks that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants