Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Support infer struct type from parquet in files() #50481

Merged
merged 2 commits into from
Sep 2, 2024
Merged

[Enhancement] Support infer struct type from parquet in files() #50481

merged 2 commits into from
Sep 2, 2024

Conversation

wyb
Copy link
Contributor

@wyb wyb commented Aug 30, 2024 •
edited
Loading

Why I'm doing:

mysql> select * from  files("path" = "hive_struct_timestamp0.parquet", "format" = "parquet";
ERROR 1064 (HY000): arrow type 18 is not supported

struct<a datetime> is not supported

struct type is infered to varchar or json type.

What I'm doing:

support struct type

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@wyb wyb requested a review from a team as a code owner August 30, 2024 09:51
@github-actions github-actions bot added the 3.3 label Aug 30, 2024
@mergify mergify bot assigned wyb Aug 30, 2024
@wyb wyb force-pushed the parquet_infer_struct branch 2 times, most recently from 2842eb7 to 0c453d0 Compare September 2, 2024 06:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

[BE Incremental Coverage Report]

✅ pass : 20 / 21 (95.24%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/parquet_schema_builder.cpp 20 21 95.24% [245]

@meegoo meegoo enabled auto-merge (squash) September 2, 2024 10:26
@meegoo meegoo merged commit 37b6339 into StarRocks:main Sep 2, 2024
52 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 2, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 2, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 2, 2024
@wyb @mergify
[Enhancement] Support infer struct type from parquet in files() (#50481)
cbba168 
Signed-off-by: wyb <[email protected]>
(cherry picked from commit 37b6339)

# Conflicts:
#	test/sql/test_across_engine/R/test_sink_nested
@mergify mergify bot mentioned this pull request Sep 2, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Sep 2, 2024
@mergify @wyb
[Enhancement] Support infer struct type from parquet in files() (back…
fb9009b 
…port #50481) (#50571)

Co-authored-by: wyb <[email protected]>
@wyb
Copy link
Contributor Author

wyb commented Sep 2, 2024

https://github.com/Mergifyio backport branch-3.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 2, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 2, 2024
@wyb @mergify
[Enhancement] Support infer struct type from parquet in files() (#50481)
d7c095f 
Signed-off-by: wyb <[email protected]>
(cherry picked from commit 37b6339)

# Conflicts:
#	test/sql/test_across_engine/R/test_sink_nested
@mergify mergify bot mentioned this pull request Sep 2, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Sep 2, 2024
@mergify @wyb
[Enhancement] Support infer struct type from parquet in files() (back…
08279b7 
…port #50481) (#50580)

Co-authored-by: wyb <[email protected]>
xiangguangyxg pushed a commit to xiangguangyxg/starrocks that referenced this pull request Sep 6, 2024
@mergify @wyb @xiangguangyxg
[Enhancement] Support infer struct type from parquet in files() (back…
de7ae67 
…port StarRocks#50481) (StarRocks#50571)

Co-authored-by: wyb <[email protected]>
va-os-commits pushed a commit to va-os-commits/starrocks that referenced this pull request Sep 10, 2024
@wyb @va-os-commits
[Enhancement] Support infer struct type from parquet in files() (Star…
1028ffc 
…Rocks#50481)

Signed-off-by: wyb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr starrocks-cr left review comments

@meegoo meegoo meegoo approved these changes

@trueeyu trueeyu trueeyu approved these changes

@jaogoy jaogoy jaogoy approved these changes

@Smith-Cruise Smith-Cruise Smith-Cruise approved these changes

Assignees

@wyb wyb

Labels
3.2-merged 3.3-merged 3.3 behavior_changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wyb @meegoo @trueeyu @jaogoy @Smith-Cruise