Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] add metrics for analysis error #50250

Merged
merged 6 commits into from
Aug 26, 2024
Merged

[Enhancement] add metrics for analysis error #50250

merged 6 commits into from
Aug 26, 2024

Conversation

DanJing-coder
Copy link
Contributor

@DanJing-coder DanJing-coder commented Aug 26, 2024 •
edited by andyziye
Loading

Why I'm doing:

Currently query_err has no way to distinguish between analysis errors and starrocks internal errors.

What I'm doing:

Add metrics for analysis errors and starrocks internal errors.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@DanJing-coder DanJing-coder requested a review from a team as a code owner August 26, 2024 06:24
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 7 / 7 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/metric/MetricRepo.java 4 4 100.00% []
🔵 com/starrocks/qe/ConnectProcessor.java 3 3 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@HangyuanLiu HangyuanLiu merged commit 9b4611a into StarRocks:main Aug 26, 2024
111 of 122 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Aug 26, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Aug 26, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Aug 26, 2024
@mergify mergify bot mentioned this pull request Aug 26, 2024
Closed
42 tasks
mergify bot pushed a commit that referenced this pull request Aug 26, 2024
@DanJing-coder @mergify
[Enhancement] add metrics for analysis error (#50250)
fc9103a 
Signed-off-by: jingdan <[email protected]>
(cherry picked from commit 9b4611a)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/metric/MetricRepo.java
@mergify mergify bot mentioned this pull request Aug 26, 2024
Closed
42 tasks
mergify bot pushed a commit that referenced this pull request Aug 26, 2024
@DanJing-coder @mergify
[Enhancement] add metrics for analysis error (#50250)
610b532 
Signed-off-by: jingdan <[email protected]>
(cherry picked from commit 9b4611a)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/metric/MetricRepo.java
#	fe/fe-core/src/main/java/com/starrocks/qe/ConnectProcessor.java
@mergify mergify bot mentioned this pull request Aug 26, 2024
Closed
42 tasks
mergify bot pushed a commit that referenced this pull request Aug 26, 2024
@DanJing-coder @mergify
[Enhancement] add metrics for analysis error (#50250)
2b41605 
Signed-off-by: jingdan <[email protected]>
(cherry picked from commit 9b4611a)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/metric/MetricRepo.java
#	fe/fe-core/src/main/java/com/starrocks/qe/ConnectProcessor.java
@mergify mergify bot mentioned this pull request Aug 26, 2024
Closed
42 tasks
@DanJing-coder
Copy link
Contributor Author

https://github.com/Mergifyio backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 27, 2024

backport branch-3.1

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • any of:
    • sender-permission>=read
    • sender=github-actions[bot]

@DanJing-coder
Copy link
Contributor Author

@mergify backport branch-3.0 branch-3.1 branch-3.2 branch-3.3

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 27, 2024

backport branch-3.0 branch-3.1 branch-3.2 branch-3.3

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • any of:
    • sender-permission>=read
    • sender=github-actions[bot]

DanJing-coder added a commit to DanJing-coder/starrocks that referenced this pull request Aug 27, 2024
@DanJing-coder
[Enhancement] add metrics for analysis error (StarRocks#50250)
1d6d55c 
Signed-off-by: jingdan <[email protected]>
DanJing-coder added a commit to DanJing-coder/starrocks that referenced this pull request Aug 27, 2024
@DanJing-coder
[Enhancement] add metrics for analysis error (StarRocks#50250)
1f02f8b 
Signed-off-by: jingdan <[email protected]>
DanJing-coder added a commit to DanJing-coder/starrocks that referenced this pull request Aug 27, 2024
@DanJing-coder
[Enhancement] add metrics for analysis error (StarRocks#50250)
82f624b 
Signed-off-by: jingdan <[email protected]>
DanJing-coder added a commit to DanJing-coder/starrocks that referenced this pull request Aug 27, 2024
@DanJing-coder
[Enhancement] add metrics for analysis error (StarRocks#50250)
096b3bc 
Signed-off-by: jingdan <[email protected]>
DanJing-coder added a commit to DanJing-coder/starrocks that referenced this pull request Aug 27, 2024
@DanJing-coder
[Enhancement] add metrics for analysis error (StarRocks#50250)
b6141a2 
Signed-off-by: jingdan <[email protected]>
Signed-off-by: Dan Jing <[email protected]>
DanJing-coder added a commit to DanJing-coder/starrocks that referenced this pull request Aug 27, 2024
@DanJing-coder
[Enhancement] add metrics for analysis error (StarRocks#50250)
c365bac 
Signed-off-by: jingdan <[email protected]>
Signed-off-by: Dan Jing <[email protected]>
DanJing-coder added a commit to DanJing-coder/starrocks that referenced this pull request Aug 27, 2024
@DanJing-coder
[Enhancement] add metrics for analysis error (StarRocks#50250)
5aeec42 
Signed-off-by: jingdan <[email protected]>
Signed-off-by: Dan Jing <[email protected]>
DanJing-coder added a commit to DanJing-coder/starrocks that referenced this pull request Aug 27, 2024
@DanJing-coder
[Enhancement] add metrics for analysis error (StarRocks#50250)
3d0703e 
Signed-off-by: jingdan <[email protected]>
Signed-off-by: Dan Jing <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Aug 29, 2024
@DanJing-coder
[Enhancement] add metrics for analysis error (backport #50250) (#50326)
d405478 
Signed-off-by: jingdan <[email protected]>
Signed-off-by: Dan Jing <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Aug 29, 2024
@DanJing-coder
[Enhancement] add metrics for analysis error(backport #50250) (#50313)
8f1d86f 
Signed-off-by: jingdan <[email protected]>
Signed-off-by: Dan Jing <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Aug 29, 2024
@DanJing-coder
[Enhancement] add metrics for analysis error(backport #50250) (#50312)
6e00623 
Signed-off-by: jingdan <[email protected]>
Signed-off-by: Dan Jing <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Aug 29, 2024
@DanJing-coder
[Enhancement] add metrics for analysis error(backport #50250) (#50308)
ceee089 
Signed-off-by: jingdan <[email protected]>
Signed-off-by: Dan Jing <[email protected]>
@before-Sunrise before-Sunrise mentioned this pull request Nov 5, 2024
Merged
24 tasks
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@DanJing-coder @renzhimin7
[Enhancement] add metrics for analysis error (StarRocks#50250)
6ad716e 
Signed-off-by: jingdan <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
@mergify mergify bot mentioned this pull request Nov 11, 2024
Merged
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshangyiming nshangyiming nshangyiming approved these changes

@HangyuanLiu HangyuanLiu HangyuanLiu approved these changes

Assignees

@DanJing-coder DanJing-coder

Labels
3.0-merged 3.1-merged 3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanJing-coder @HangyuanLiu @nshangyiming