Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] split Metric "query_error" into there part #52646

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

before-Sunrise
Copy link
Contributor

@before-Sunrise before-Sunrise commented Nov 5, 2024

Why I'm doing:

#50250 add query internal error and query analysis error in FE metric, which is part of query error. But has some problem which already exists befor 50250:

  1. when query timeout, it will count to analysis error, becasue it throws UserException
  2. if one query fails in parser, no query error will be record, because at this time, ctx.getState().isQuery() is false
  3. some UserException doesn't belong to analysis error, we should set such error type to internal error. Key point is some UserException actually is not user' s probelm sucn as "BE is down but we throw DdlException which is a UserException"

What I'm doing:

  1. Fixes problem 1 and problem 2
  2. add three error rate metric: internal error rate, analysis error rate, timeout rate
  3. for problem 3, just fix what i konw: "BE is down but we throw DdlException which is a UserException"

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: before-Sunrise <[email protected]>
Signed-off-by: before-Sunrise <[email protected]>
@before-Sunrise before-Sunrise requested a review from a team as a code owner November 5, 2024 11:55
@github-actions github-actions bot added the 3.3 label Nov 5, 2024
Signed-off-by: before-Sunrise <[email protected]>
Copy link

sonarcloud bot commented Nov 6, 2024

Copy link

github-actions bot commented Nov 6, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Nov 6, 2024

[FE Incremental Coverage Report]

fail : 35 / 47 (74.47%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/common/Status.java 0 3 00.00% [150, 151, 152]
🔵 com/starrocks/qe/ResultReceiver.java 0 1 00.00% [150]
🔵 com/starrocks/qe/StmtExecutor.java 3 8 37.50% [757, 759, 2328, 2332, 2338]
🔵 com/starrocks/common/ErrorReport.java 1 2 50.00% [109]
🔵 com/starrocks/qe/DefaultCoordinator.java 1 2 50.00% [913]
🔵 com/starrocks/qe/ConnectProcessor.java 2 3 66.67% [223]
🔵 com/starrocks/metric/MetricRepo.java 9 9 100.00% []
🔵 com/starrocks/qe/QueryState.java 1 1 100.00% []
🔵 com/starrocks/metric/MetricCalculator.java 18 18 100.00% []

Copy link

github-actions bot commented Nov 6, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

} else {
// TODO: some UserException doesn't belong to analysis error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should we find out this kind of error?

@silverbullet233 silverbullet233 enabled auto-merge (squash) November 7, 2024 03:22
@kangkaisen kangkaisen merged commit 932b28a into StarRocks:main Nov 11, 2024
61 of 62 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Nov 11, 2024
Copy link
Contributor

mergify bot commented Nov 11, 2024

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 11, 2024
Signed-off-by: before-Sunrise <[email protected]>
(cherry picked from commit 932b28a)
wanpengfei-git pushed a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants