Archive Scheme and Create XCFramework workflows #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippzagar
changed the title
Merged
1 task
PSchmiedmayer
requested changes
Nov 9, 2023
|
@PSchmiedmayer Ready to review again! |
PSchmiedmayer
approved these changes
Nov 9, 2023
philippzagar
deleted the
feat/add-archive-and-xcframework-template-workflows
branch
philippzagar
added a commit
that referenced
this pull request
Nov 9, 2023
# Fix nested reusable workflow ## ♻️ Current situation & Problem The original PR #40 contained an issue that reusable workflows must specify the full path of the nested reusable workflow in order to work properly. Furthermore, one must pay attention to where the JSON decoding of the `runs-on` arguments is done. ## ⚙️ Release Notes - Fixes an issue with the newly introduced XCFramework reusable workflow ## 📚 Documentation -- ## ✅ Testing -- ### Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md): - [X] I agree to follow the [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md). --------- Signed-off-by: Philipp Zagar <[email protected]>
philippzagar
added a commit
to StanfordBDHG/ResearchKit
that referenced
this pull request
Nov 10, 2023
…ork (#9) # Use template GitHub workflows for archiving and creating the XCFramework ## ♻️ Current situation & Problem In StanfordBDHG/.github#40, we introduced reusable GitHub Actions workflows for the archiving and creation of XCFrameworks. This enables us to avoid code duplication. ## ⚙️ Release Notes - GitHub Actions workflow utilizes shared reusable workflows. - ResearchKit updated to latest version v2.2.12 ## 📚 Documentation Provided in the workflow files ## ✅ Testing Manually tested by creating an example release of ResearchKit. ### Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md): - [X] I agree to follow the [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md). --------- Co-authored-by: Pariece McKinney <[email protected]> Co-authored-by: philippzagar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Archive Scheme and Create XCFramework reusable workflows
♻️ Current situation & Problem
At the moment, the StanfordBDHG fork of llama.cpp as well as the fork of ResearchKit require a GitHub Actions workflow that archives a scheme and creates an XCFramework that is then published in a tagged release.
As both of these repositories need these functionalities, there is substantial code duplication.
⚙️ Release Notes
📚 Documentation
Provided within the GitHub Action workflow files.
✅ Testing
Workflows have been tested manually.
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: