Use reusable GitHub workflows for archiving and creating the XCFramework #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed `ORKHealthKitQuantityTypeAnswerFormat`issues - Improved `ORKReviewStep` initialization - Introduced a new property called `shouldAutomaticallyAdjustImageTintColor` on `ORKStep` to automatically adopt dark mode version of an image - Added `ORKSESQuestionResult` to Table View Providers - ORKCatalog Improvements - ORKImageSelectionView improvements - Bumped version to 2.2.12
…-and-xcframework-template-workflows
philippzagar
force-pushed
the
feat/use-archive-and-xcframework-template-workflows
branch
from
3677a9f to
98dbd4e
Compare
|
@PSchmiedmayer Just created a new release via the reusable GitHub Actions workflows, worked fine: https://github.com/StanfordBDHG/ResearchKit/releases/tag/2.2.19 Feel free to check the (minimal) code changes (most of the diff comes from upstream ResearchKit) 🚀 |
…-template-workflows' into feat/use-archive-and-xcframework-template-workflows
1 task
PSchmiedmayer
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Thank you for all the improvements. I had a few minor comments that I noted in the review, would be great if those are addressed before we merge the PR.
Thanks for all the work here to make this reusable 🚀
No need for an other review from my side once these issues are addressed and you validated that the feature branch is working using an external package and tests 👍
philippzagar
deleted the
feat/use-archive-and-xcframework-template-workflows
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use template GitHub workflows for archiving and creating the XCFramework
♻️ Current situation & Problem
In StanfordBDHG/.github#40, we introduced reusable GitHub Actions workflows for the archiving and creation of XCFrameworks. This enables us to avoid code duplication.
⚙️ Release Notes
📚 Documentation
Provided in the workflow files
✅ Testing
Manually tested by creating an example release of ResearchKit.
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: