Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose binary thruster control #21

Merged
merged 16 commits into from
Jan 16, 2024
Merged

Expose binary thruster control #21

merged 16 commits into from
Jan 16, 2024

Conversation

alvinsunyixiao
Copy link
Contributor

No description provided.

@alvinsunyixiao alvinsunyixiao marked this pull request as draft January 10, 2024 00:21
@alvinsunyixiao alvinsunyixiao marked this pull request as ready for review January 10, 2024 07:57
AndrewHWang1605
AndrewHWang1605 approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@AndrewHWang1605 AndrewHWang1605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to me that the framework is still there to control w/PWM, but safety filter in its current form only takes in binary on/off commands. If that's correct, this code makes sense to me!

@alvinsunyixiao alvinsunyixiao merged commit a62d895 into main Jan 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewHWang1605 AndrewHWang1605 AndrewHWang1605 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvinsunyixiao @AndrewHWang1605