Skip to content

Issues: StErMi/rareblocks-rent-poc

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9 Open 5 Closed
9 Open 5 Closed
Author
Filter by author
Loading
Label
Filter by label
Loading
Use alt + click/return to exclude labels
or ⇧ + click/return for logical OR
Projects
Filter by project
Loading
Milestones
Filter by milestone
Loading
Assignee
Filter by who’s assigned
Sort
Sort by
Newest Oldest Most commented Least commented Recently updated Least recently updated Best match
Most reactions
👍 👎 😄 🎉 😕 ❤️ 🚀 👀

Issues list

Invest further with tests if after doing stakers.remove (EnumerableSet) that position will be empty or just directly removed further investigation need further investigation
#14 opened Feb 13, 2022 by StErMi
updateAllowedSubscriptions should emit a AllowedSubscriptionsUpdate event and not for a single one help wanted Extra attention is needed
#12 opened Feb 13, 2022 by StErMi
remove indexed keyword from onlyOwner events help wanted Extra attention is needed
#11 opened Feb 13, 2022 by StErMi
subscribe function could useunchecked for gas saving wontfix This will not be worked on
#10 opened Feb 13, 2022 by StErMi
change rareBlocksStaking and newRareBlocksStaking addresses as indexed param of relative events help wanted Extra attention is needed
#9 opened Feb 13, 2022 by StErMi
ensure that contract has enough balance to send it to staker contract adding check on address(this).balance >= stakingBalance further investigation need further investigation
#8 opened Feb 13, 2022 by StErMi
Define the correct amount of days for subscription period help wanted Extra attention is needed
#7 opened Feb 13, 2022 by StErMi
NOT_ENOUGH_FUNDS error message on subscribe could be confusing help wanted Extra attention is needed
#6 opened Feb 13, 2022 by StErMi
setMaxSubscriptions should check newMaxSubscriptions != 0 help wanted Extra attention is needed
#3 opened Feb 13, 2022 by StErMi
ProTip! Find all open issues with in progress development work with linked:pr.