Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the correct amount of days for subscription period #7

Open
StErMi opened this issue Feb 13, 2022 · 0 comments
Open

Define the correct amount of days for subscription period #7

StErMi opened this issue Feb 13, 2022 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@StErMi
Copy link
Owner

StErMi commented Feb 13, 2022

@dannypostma you have defined the subscription period as 1 month. In solidity, we have translated to 31 days that could be incorrect because if you subscribe for 12 months it would be 372 days.

@dannypostma if we change the period (1 month) to 365.25 days / 12 should we also change the value of STAKE_LOCK_PERIOD in RareBlocksStaking to that value?

@StErMi StErMi added the help wanted Extra attention is needed label Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant